Re: [Kimchi-devel] [PATCH] Python: Do not allow lines longer than 80 characters
Hi Mark, thanks for the feedback!
I haven't read the PEP8 correctly, I thought the length limit was 80
characters, but I see it's 79 indeed.
I decided to validate only this PEP8 feature for now (maximum line
length) for all files instead of completely cleaning file by file. At
least now there'll be one less rule left :-)
I'll send a new patch fixing the new line length value.
Am 21-01-2014 23:41, schrieb Mark Wu:
Hi Crístian,
I like the idea of cleanup, but for python projects, we should
comply with PEP8[1], which limit all lines to a maximum of 79
characters. So after we can all files pep clean, it will resolve
the line length problem too.
If you have interest in the pep8 clean, you could use the command
line tool pep8 and or vim plugin[2] to check if a python file is pep8
clean. After the cleanup, we need put it to the list of
PEP8_WHITELIST in Makefile.am. It can guarantee the files are checked
when 'make check-local' is executed.
[1] http://www.python.org/dev/peps/pep-0008/#maximum-line-length
[2]
https://github.com/kimchi-project/kimchi/wiki/PEP8-Checking-Using-Syntastic
Attachments:
- attachment.html (text/html — 2.4 KB)