Re: [Kimchi-devel] [PATCH] Change all CSS files indentation to 4 spaces
Am 20-01-2014 13:59, schrieb Aline Manera:
> background: -webkit-gradient(linear, left top, left bottom,
> color-stop(0%, #f3f3f3), color-stop(50%, #dddddd),
> - color-stop(51%, #d8d8d8), color-stop(100%, #cccccc));
> + color-stop(51%, #d8d8d8), color-stop(100%, #cccccc));
In this case, the second line is a continuation of the first one. So I
suggest to indent it as following:
background: -webkit-gradient(linear, left top, left bottom,
color-stop(0%, #f3f3f3), color-stop(50%, #dddddd),
color-stop(51%, #d8d8d8), color-stop(100%, #cccccc));
You're right, the second line is a continuation of the first one, the
patch ignored that. But we need to set a maximum line length, otherwise
we can also merge those two lines into one. Should we keep the maximum
length at 80 for the CSS files as well? I'll send another patch fixing
those issues.