Re: [Kimchi-devel] [PATCH] [wip-v1] Create template from guest (BACKEND)
On 26-08-2014 11:23, Rodrigo Trujillo wrote:
+ def _get_vm_params(self, vm):
+ from kimchi.model.vms import VMModel
I'd suggest importing modules at the top of the file, not where they're
used. There are other occurrences of this in the rest of the code.
And what will happen if the user sets the parameter 'vm' as well as
other values (e.g. 'cdrom', 'cpus', etc)? According to this code, the
parameter 'vm' will override whatever has been set before. Is that
expected? I think this should be documented somewhere, probably at
src/kimchi/API.json.