Re: [Kimchi-devel] [V2 0/2] Authorization: Add users/groups to VM

Looks good for me. But we need to allow change the VM permissions when it is running I've just tested it and it works fine using the REST API. My suggestion is replace the "Manage Media" menu option to "Edit" when VM is running. And add the same tab layout there. One tab for "Storage" - to manage media, and other one for "Permission" Also it would be good to have the same layout on "Storage" tab we have when the VM is stopped. Let me know how much is needed to have it done so we can split it into smaller tasks or drop this to sprint 2.

And if you don't mind, I have one more suggestion to make. Add the same column headers to the selected users/groups box.

On 07/22/2014 06:33 AM, huoyuxin(a)linux.vnet.ibm.com wrote: > From: Yu Xin Huo<huoyuxin(a)linux.vnet.ibm.com> > > Yu Xin Huo (2): > Add users/groups to VM > po files update for permission > > po/en_US.po | 9 +++ > po/kimchi.pot | 9 +++ > po/pt_BR.po | 9 +++ > po/zh_CN.po | 9 +++ > ui/css/theme-default/guest-edit.css | 116 +++++++++++++++++++++++++++++++++++ > ui/images/theme-default/group.png | Bin 0 -> 1703 bytes > ui/images/theme-default/user.png | Bin 0 -> 1322 bytes > ui/js/src/kimchi.api.js | 28 ++++++++ > ui/js/src/kimchi.guest_edit_main.js | 112 ++++++++++++++++++++++++++++++++- > ui/pages/guest-edit.html.tmpl | 37 +++++++++++ > 10 files changed, 326 insertions(+), 3 deletions(-) > create mode 100644 ui/images/theme-default/group.png > create mode 100644 ui/images/theme-default/user.png > > _______________________________________________ > Kimchi-devel mailing list > Kimchi-devel(a)ovirt.org > http://lists.ovirt.org/mailman/listinfo/kimchi-devel >