Re: [Kimchi-devel] [PATCH V4 0/5] Storagepool SCSI/FC

On 02/10/2014 11:22 AM, Aline Manera wrote: > > The UI looks distorted when all options are available to create the > storage pool: > > http://picpaste.com/_8EA4BB37FF97475-ItaBa6cJ.jpg > And when creating a virtual machine from a Template which points to a SCSI pool, if I don't select any LUN to create the vm disk the popup is closed and an error message appears on top of the page "No LUN selected". You should display the error with the window open so user have a chance do update it and just close the popup when the required field is provided.

> On 02/05/2014 12:18 PM, Rodrigo Trujillo wrote: >> V4: >> - Implements mockmodel and tests >> - Fix UI >> - Fix other minor issues >> >> >> V3: >> - Changed API to only receive the scsi host name when creating new pool >> - Changed API to require LUN when creating new VM on SCSI pool >> - Created feature test and removed libvirt test function >> - Rebased with new model structure >> - Added error function handlers to UIs >> - Fixed LUN selection window >> >> >> V2: >> >> - Implements Fibre Channel devices discover in the host >> - Allow vms_create receive a volume to create the disk (if pool is >> SCSI) >> - Create basic UI to select SCSI Host when creating SCSI FC pool >> - Draft of UI to select LUN to create new VM when template has a SCSI >> pool configured. (Need help of UI guys here!) >> >> Rodrigo Trujillo (5): >> Storagepool SCSI/FC: Implement node devices API backend >> Storagepool SCSI/FC: Backend implementation >> Storagepool SCSI/FC: Implement UI for FC scsi_host pool >> Storagepool SCSI/FC: Modifies UI flow to select a LUN to new VM >> Storagepool SCSI/FC: Modifies mockmodel and implements tests for FC >> pool >> >> docs/API.md | 5 ++- >> src/kimchi/API.json | 14 +++++- >> src/kimchi/control/host.py | 16 +++++++ >> src/kimchi/featuretests.py | 27 ++++++++++++ >> src/kimchi/mockmodel.py | 53 ++++++++++++++++++++--- >> src/kimchi/model/config.py | 5 ++- >> src/kimchi/model/host.py | 54 +++++++++++++++++++++++ >> src/kimchi/model/libvirtstoragepool.py | 48 ++++++++++++++++++++- >> src/kimchi/model/storagepools.py | 22 ++++++++-- >> src/kimchi/model/templates.py | 5 +++ >> src/kimchi/model/vms.py | 25 ++++++++++- >> src/kimchi/vmtemplate.py | 31 +++++++++++++- >> tests/test_rest.py | 47 ++++++++++++++++++++ >> tests/test_storagepool.py | 21 +++++++++ >> ui/js/src/kimchi.api.js | 24 +++++++++++ >> ui/js/src/kimchi.guest_add_main.js | 73 >> ++++++++++++++++++++++++++++++-- >> ui/js/src/kimchi.storagepool_add_main.js | 46 +++++++++++++++++++- >> ui/pages/i18n.html.tmpl | 5 +++ >> ui/pages/storagepool-add.html.tmpl | 12 ++++++ >> 19 files changed, 510 insertions(+), 23 deletions(-) >> > > _______________________________________________ > Kimchi-devel mailing list > Kimchi-devel(a)ovirt.org > http://lists.ovirt.org/mailman/listinfo/kimchi-devel > _______________________________________________ Kimchi-devel mailing list Kimchi-devel(a)ovirt.org http://lists.ovirt.org/mailman/listinfo/kimchi-devel