Re: [Kimchi-devel] [PATCH v5 0/6] Async VM Creation

Christy, I reviewed the backend patches and I don't have any comments to make. I am going to apply them so you just need to resend the UI part.

On 27/04/2015 14:28, Christy Perez wrote: > v5 Changes: > - Rebase > - Remove all the unimperative target_uri changes (see below) > > If a guest has a large disk, and uses a filesystem that requires > preallocation, it can take several minutes to create a VM. During that > time, kimchi is tied up by the VM creation. > > This patch changes the VMs Collection to be an AsyncCollection. > > Another change required for this was to create a more granular way to > query vm-related tasks. The original idea was to add another field to > the > task database, but then Aline suggested just modifying the task_uri. > Since > the task_uri cretation will be changed in a future patchset, this is > now only modified for the conflicting (clone) tasks. > > Christy Perez (6): > Append clone to target_uri for vm clone task > Tests for new clone target_uri > UI changes for new clone target_uri > Create VMs asynchronously: Backend > Create VMs Asynchronously: Tests > Create VMs Asynchronously: UI > > src/kimchi/control/vms.py | 4 +-- > src/kimchi/model/vms.py | 32 +++++++++++++++++---- > tests/test_authorization.py | 23 +++++++++------ > tests/test_mockmodel.py | 12 ++++++-- > tests/test_model.py | 49 > +++++++++++++++++++++----------- > tests/test_model_storagevolume.py | 2 +- > tests/test_rest.py | 60 > +++++++++++++++++++++++++++++---------- > ui/css/theme-default/list.css | 18 ++++++++++++ > ui/js/src/kimchi.guest_main.js | 29 +++++++++++++++---- > ui/pages/guest.html.tmpl | 3 ++ > 10 files changed, 175 insertions(+), 57 deletions(-) > _______________________________________________ Kimchi-devel mailing list Kimchi-devel(a)ovirt.org http://lists.ovirt.org/mailman/listinfo/kimchi-devel