Re: [Kimchi-devel] [PATCH] [Wok] Issue #79: All error messages should keep on UI until user dismiss it
Hi Samuel,
I noticed the following in Kimchi after applying your patch with some of
the scenarios I ran:
Click on Add a Storage, enter any invalid info and click on Create button:
Error shows on parent panel, not main panel although the error does
not disappear on its own which is the intent.
I think we've encountered this problem before where the error shows
on parent panel instead of main panel.
Click on Add Template, enter any path in File Path, click on Create button:
Error shows on main panel, but no X (and it doesn't disappear
either which is the intent)
In both cases, prior to your patch the error messages would disappear
after a few seconds and with your patch now
the messages stay until user closes them so that part seems to work.
Thanks
-Socorro
On 06/22/2016 08:45 AM, sguimaraes943(a)gmail.com wrote:
From: Samuel Guimarães <sguimaraes943(a)gmail.com>
This commit makes all messages closeable by default, removing the fade animation after 10
seconds.
A parameter to allow a custom ID for each alert was also added to wok.message function.
Samuel Guimarães (1):
Issue #79: All error messages should keep on UI until user dismiss it
ui/js/src/wok.message.js | 53 +++++++++++++++++++++++++-----------------------
1 file changed, 28 insertions(+), 25 deletions(-)