On 02/19/2015 01:38 PM, Aline Manera wrote:
On 16/02/2015 19:26, Christy Perez wrote:
> The patch is the manual changes only, without running the make
> commands. There are a lot of other translation changes that will
> be pulled in after a make, so I'm leaving that step out for
> simplicity when reviewing this patch.
>
> If needed, I can run make and re-submit after review.
Running the make command, you point to you the fuzzy messages which
needs to have the translation message clean up.
A lot of messages ended up with the fuzzy statement when I ran the make
commands. Not this message, though. Are you asking me to review all the
other messages?
Here's an example:
+#, fuzzy, python-format
+msgid "The interface %(iface)s already exist."
+msgstr "Vorlage %(name)s ist bereits vorhanden"
+
Regards,
Some comments below:
>
> Signed-off-by: Christy Perez <christy(a)linux.vnet.ibm.com>
> ---
> po/de_DE.po | 2 +-
> po/en_US.po | 2 +-
> po/es_ES.po | 2 +-
> po/fr_FR.po | 2 +-
> po/it_IT.po | 2 +-
> po/ja_JP.po | 2 +-
> po/kimchi.pot | 2 +-
> po/ko_KR.po | 2 +-
> po/pt_BR.po | 2 +-
> po/ru_RU.po | 2 +-
> po/zh_CN.po | 2 +-
> po/zh_TW.po | 2 +-
> ui/pages/i18n.json.tmpl | 2 +-
> 13 files changed, 13 insertions(+), 13 deletions(-)
>
> diff --git a/po/de_DE.po b/po/de_DE.po
> index 5116d1f..a730040 100644
> --- a/po/de_DE.po
> +++ b/po/de_DE.po
> @@ -1466,7 +1466,7 @@ msgstr ""
> msgid "This is not a valid ISO file."
> msgstr "Dies ist keine gültige ISO-Datei."
>
> -msgid "It will take long time. Do you want to continue?"
> +msgid "This may take a long time. Do you want to continue?"
> msgstr "Dies wird einige Zeit dauern. Möchten Sie fortfahren?"
As the msgid has changed you need to clean up the msgstr otherwise we
will have a inconsistent state.
Those cases would be covered by the "#fuzzy" statement when running make.
This also applies to all the other files.
> msgid "This will permanently delete the template. Would you like to
> continue?"
> diff --git a/po/en_US.po b/po/en_US.po
> index 05ca48a..8c3aeda 100644
> --- a/po/en_US.po
> +++ b/po/en_US.po
> @@ -1338,7 +1338,7 @@ msgstr ""
> msgid "This is not a valid ISO file."
> msgstr ""
>
> -msgid "It will take long time. Do you want to continue?"
> +msgid "This may take a long time. Do you want to continue?"
> msgstr ""
>
> msgid "This will permanently delete the template. Would you like to
> continue?"
> diff --git a/po/es_ES.po b/po/es_ES.po
> index 573dc03..f9c26fe 100644
> --- a/po/es_ES.po
> +++ b/po/es_ES.po
> @@ -1485,7 +1485,7 @@ msgstr ""
> msgid "This is not a valid ISO file."
> msgstr "No es un archivo ISO válido."
>
> -msgid "It will take long time. Do you want to continue?"
> +msgid "This may take a long time. Do you want to continue?"
> msgstr "Tardará mucho tiempo. ¿Desea continuar?"
>
> msgid "This will permanently delete the template. Would you like to
> continue?"
> diff --git a/po/fr_FR.po b/po/fr_FR.po
> index 715d612..ad3abb2 100644
> --- a/po/fr_FR.po
> +++ b/po/fr_FR.po
> @@ -1502,7 +1502,7 @@ msgstr "Aucune ISO détectée"
> msgid "This is not a valid ISO file."
> msgstr "Ce n'est pas un fichier ISO valide."
>
> -msgid "It will take long time. Do you want to continue?"
> +msgid "This may take a long time. Do you want to continue?"
> msgstr "Cela va prendre un long moment. Voulez-vous continuer ?"
>
> msgid "This will permanently delete the template. Would you like to
> continue?"
> diff --git a/po/it_IT.po b/po/it_IT.po
> index 1746bed..759f4a2 100644
> --- a/po/it_IT.po
> +++ b/po/it_IT.po
> @@ -1454,7 +1454,7 @@ msgstr ""
> msgid "This is not a valid ISO file."
> msgstr "Non è un file ISO valido."
>
> -msgid "It will take long time. Do you want to continue?"
> +msgid "This may take a long time. Do you want to continue?"
> msgstr "Richiederà molto tempo. Continuare?"
>
> msgid "This will permanently delete the template. Would you like to
> continue?"
> diff --git a/po/ja_JP.po b/po/ja_JP.po
> index f9fe5ee..c28d764 100644
> --- a/po/ja_JP.po
> +++ b/po/ja_JP.po
> @@ -1463,7 +1463,7 @@ msgstr ""
> msgid "This is not a valid ISO file."
> msgstr "有効な ISO ファイルではありません。"
>
> -msgid "It will take long time. Do you want to continue?"
> +msgid "This may take a long time. Do you want to continue?"
> msgstr "しばらく時間がかかることがあります。続行しますか?"
>
> msgid "This will permanently delete the template. Would you like to
> continue?"
> diff --git a/po/kimchi.pot b/po/kimchi.pot
> index 1923fad..f2456f3 100755
> --- a/po/kimchi.pot
> +++ b/po/kimchi.pot
> @@ -1338,7 +1338,7 @@ msgstr ""
> msgid "This is not a valid ISO file."
> msgstr ""
>
> -msgid "It will take long time. Do you want to continue?"
> +msgid "This may take a long time. Do you want to continue?"
> msgstr ""
>
> msgid "This will permanently delete the template. Would you like to
> continue?"
> diff --git a/po/ko_KR.po b/po/ko_KR.po
> index 0f6f530..2d01193 100644
> --- a/po/ko_KR.po
> +++ b/po/ko_KR.po
> @@ -1395,7 +1395,7 @@ msgstr ""
> msgid "This is not a valid ISO file."
> msgstr "올바른 ISO 파일이 아닙니다."
>
> -msgid "It will take long time. Do you want to continue?"
> +msgid "This may take a long time. Do you want to continue?"
> msgstr "시간이 오래 걸립니다. 계속하시겠습니까?"
>
> msgid "This will permanently delete the template. Would you like to
> continue?"
> diff --git a/po/pt_BR.po b/po/pt_BR.po
> index 898ee5d..10ac33e 100644
> --- a/po/pt_BR.po
> +++ b/po/pt_BR.po
> @@ -1513,7 +1513,7 @@ msgstr "Nenhuma ISO encontrada"
> msgid "This is not a valid ISO file."
> msgstr "Esse não é um arquivo ISO válido."
>
> -msgid "It will take long time. Do you want to continue?"
> +msgid "This may take a long time. Do you want to continue?"
> msgstr "Isso vai levar um longo tempo. Deseja continuar?"
>
> msgid "This will permanently delete the template. Would you like to
> continue?"
> diff --git a/po/ru_RU.po b/po/ru_RU.po
> index fa8d121..8233e99 100644
> --- a/po/ru_RU.po
> +++ b/po/ru_RU.po
> @@ -1396,7 +1396,7 @@ msgstr ""
> msgid "This is not a valid ISO file."
> msgstr "Этот файл не является допустимым образом ISO."
>
> -msgid "It will take long time. Do you want to continue?"
> +msgid "This may take a long time. Do you want to continue?"
> msgstr "Это займет много времени. Продолжить?"
>
> msgid "This will permanently delete the template. Would you like to
> continue?"
> diff --git a/po/zh_CN.po b/po/zh_CN.po
> index 82d2980..a307e3b 100644
> --- a/po/zh_CN.po
> +++ b/po/zh_CN.po
> @@ -1372,7 +1372,7 @@ msgstr "没有发现ISO文件"
> msgid "This is not a valid ISO file."
> msgstr "这不是一个有效的ISO文件"
>
> -msgid "It will take long time. Do you want to continue?"
> +msgid "This may take a long time. Do you want to continue?"
> msgstr "这需要一段时间。是否继续?"
>
> msgid "This will permanently delete the template. Would you like to
> continue?"
> diff --git a/po/zh_TW.po b/po/zh_TW.po
> index a12a56e..776bd52 100644
> --- a/po/zh_TW.po
> +++ b/po/zh_TW.po
> @@ -1343,7 +1343,7 @@ msgstr ""
> msgid "This is not a valid ISO file."
> msgstr "這是無效的 ISO 檔案。"
>
> -msgid "It will take long time. Do you want to continue?"
> +msgid "This may take a long time. Do you want to continue?"
> msgstr "它將需要很長時間。要繼續嗎?"
>
> msgid "This will permanently delete the template. Would you like to
> continue?"
> diff --git a/ui/pages/i18n.json.tmpl b/ui/pages/i18n.json.tmpl
> index a4a6dd5..b170d26 100644
> --- a/ui/pages/i18n.json.tmpl
> +++ b/ui/pages/i18n.json.tmpl
> @@ -58,7 +58,7 @@
>
> "KCHTMPL6002E": "$_("This is not a valid ISO
file.")",
>
> - "KCHTMPL6002M": "$_("It will take long time. Do you want to
> continue?")",
> + "KCHTMPL6002M": "$_("This may take a long time. Do you want
to
> continue?")",
> "KCHTMPL6003M": "$_("This will permanently delete the
template.
> Would you like to continue?")",
>
> "KCHHOST6001E": "$_("Unable to shut down system as there
are
> some virtual machines running!")",
>
>
> _______________________________________________
> Kimchi-devel mailing list
> Kimchi-devel(a)ovirt.org
>
http://lists.ovirt.org/mailman/listinfo/kimchi-devel