Re: [Kimchi-devel] [PATCHv2 0/2] UI for LDAP support
Some style comments:
1. Storage, Network and Permission (when ldap) tabs will have a similar
layout so all those 3 tabs should share the same margin and alignment
values.
Network and Storage differs on margins values.
The Permission tab differs on margin and alignment from the other 2.
Also the plus icon is over the line.
So I'd suggest to have those margin and alignment values shared in all
those 3 tabs.
2. I think the user input box (when I select the plus icon on Permission
tab) should be bigger, like 2x the current width
On 11/20/2014 08:22 AM, lvroyce(a)linux.vnet.ibm.com wrote:
From: Royce Lv <lvroyce(a)linux.vnet.ibm.com>
v1>v2,
Change according to backend API change.
Royce Lv (2):
UI: support ldap vm permission tag
Change guest edit permission logic
ui/css/theme-default/guest-edit.css | 79 +++++++---
ui/js/src/kimchi.api.js | 15 +-
ui/js/src/kimchi.guest_edit_main.js | 300 ++++++++++++++++++++++++------------
ui/pages/guest-edit.html.tmpl | 28 +++-
4 files changed, 299 insertions(+), 123 deletions(-)
Attachments:
- cghibbhi. (image/jpeg — 11.2 KB)
- ifffajib. (image/jpeg — 15.6 KB)
- jbjhhfig. (image/jpeg — 10.3 KB)
- attachment.html (text/html — 2.0 KB)