Just a minor comment below
On 02/25/2014 12:21 AM, Aline Manera wrote:
From: Aline Manera <alinefm(a)br.ibm.com>
Any character is allowed in a Linux path.
So while creating a DIR storage pool we just need to make sure the path
starts with '/' and backend will properly check if it exists on the
system.
Signed-off-by: Aline Manera <alinefm(a)br.ibm.com>
---
ui/js/src/kimchi.storagepool_add_main.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ui/js/src/kimchi.storagepool_add_main.js
b/ui/js/src/kimchi.storagepool_add_main.js
index 574cf5a..1e3e4b4 100644
--- a/ui/js/src/kimchi.storagepool_add_main.js
+++ b/ui/js/src/kimchi.storagepool_add_main.js
@@ -167,7 +167,7 @@ kimchi.validateDirForm = function () {
kimchi.message.error.code('KCHPOOL6002E');
return false;
}
- if (!/((\/([0-9a-zA-Z-_\.]+)))$/.test(path)) {
+ if (!/(^\/.*)$/.test(path)) {
if just verify path starts with '/',
path.startsWith("/")
is OK.
sure, your RE is also OK. :-)
kimchi.message.error.code('KCHAPI6003E');
return false;
}
--
Thanks and best regards!
Sheldon Feng(冯少合)<shaohef(a)linux.vnet.ibm.com>
IBM Linux Technology Center