
'make check-local' is failing as below: Checking for invalid i18n string... Checking for invalid i18n string successfully find . -path './.git' -prune -type f -o \ -name '*.py' -o -name '*.py.in' | xargs /usr/bin/pyflakes | \ grep -w -v "\./src/kimchi/websocket\.py" | \ while read LINE; do echo "$LINE"; false; done ./src/kimchi/yumparser.py:22: 'join' imported but unused ./src/kimchi/yumparser.py:22: 'getmtime' imported but unused Makefile:909: recipe for target 'check-local' failed make: *** [check-local] Error 1 And 'make check' is failing on Ubuntu: ====================================================================== ERROR: setUpModule (test_yumparser) [05/Jun/2015:14:44:45] ENGINE Waiting for child threads to terminate... ---------------------------------------------------------------------- Traceback (most recent call last): File "test_yumparser.py", line 65, in setUpModule TEMP_REPO_FILE = _create_fake_repos_file() File "test_yumparser.py", line 50, in _create_fake_repos_file dir='/etc/yum.repos.d') File "/usr/lib/python2.7/tempfile.py", line 308, in mkstemp return _mkstemp_inner(dir, prefix, suffix, flags) File "/usr/lib/python2.7/tempfile.py", line 239, in _mkstemp_inner fd = _os.open(file, flags, 0600) OSError: [Errno 2] No such file or directory: '/etc/yum.repos.d/tmp_Ml11K.repo' On 04/06/2015 16:49, Daniel Henrique Barboza wrote:
The use of Yum API is causing a memory leak each time the Host tab is loaded. This can be verified by seeing the use of memory in $top.
To remove the Yum API, a new module named 'yumparser' was created to manipulate Yum repositories directly from the filesystem and to return the software update list by parsing $yum check-update command.
A new unit test file was created to verify the proper behavior of the yumparser module.
Daniel Henrique Barboza (3): Adding yumparser module Unit tests for the yumparser module Changing repositories and swupdate to use yumparser module
src/kimchi/repositories.py | 65 ++++------- src/kimchi/swupdate.py | 16 +-- src/kimchi/yumparser.py | 271 +++++++++++++++++++++++++++++++++++++++++++++ tests/test_yumparser.py | 109 ++++++++++++++++++ 4 files changed, 406 insertions(+), 55 deletions(-) create mode 100644 src/kimchi/yumparser.py create mode 100644 tests/test_yumparser.py