Reviewed-By: Paulo Vital <pvital@linux.vnet.ibm.com> On Wed, 2015-10-21 at 21:40 -0200, Aline Manera wrote:
Hi all,
With this patch set, all the test cases passed on my Ubuntu system. \o/
While testing it, please, make sure your system does not have any leftovers from the previous attempts to run make-check.
Run the following commands to make sure your system only has what it is expected:
sudo virsh list --all sudo virsh net-list --all sudo virsh pool-list --all sudo ls -lha /var/lib/libvirt/images sudo ls -lhs <kimchi-dir>/data/debugreports
And on Fedora, the failures were reduced to 4. I will investigate them later. Below is the output from 'make check' on my Fedora system:
===================================================================== = FAIL: test_storagevolume_action (test_model_storagevolume.StorageVolumeTests) --------------------------------------------------------------------- - Traceback (most recent call last): File "test_model_storagevolume.py", line 280, in test_storagevolume_action _do_volume_test(self, model, host, ssl_port, 'default') File "test_model_storagevolume.py", line 122, in _do_volume_test self.assertEquals(500, resp.status) AssertionError: 500 != 200
[21/Oct/2015:21:19:58] ENGINE Waiting for child threads to terminate... ===================================================================== = FAIL: test_async_tasks (test_model.ModelTests) --------------------------------------------------------------------- - Traceback (most recent call last): File "test_model.py", line 917, in test_async_tasks self.assertEquals(1, taskid) AssertionError: 1 != 2
===================================================================== = FAIL: test_debug_reports (test_model.ModelTests) --------------------------------------------------------------------- - Traceback (most recent call last): File "test_model.py", line 1098, in test_debug_reports "It is not necessary an error. " AssertionError: It is not necessary an error. You may need to increase the timeout number by TEST_REPORT_TIMEOUT=200 ./run_tests.sh test_model
===================================================================== = FAIL: test_vlan_tag_bridge (test_mock_network.MockNetworkTests) --------------------------------------------------------------------- - Traceback (most recent call last): File "test_mock_network.py", line 73, in test_vlan_tag_bridge 'interface': iface, 'vlan_id': 987}) File "test_model_network.py", line 70, in _do_network_test self.assertEquals(201, resp.status) AssertionError: 201 != 500
--------------------------------------------------------------------- - Ran 121 tests in 215.991s FAILED (failures=4)
Aline Manera (6): Force a HTTP redirection when a resource has its ID changed after a PUT request Make sure to use relative path when setting an icon to a guest Update test case to use the right Template URI while creating a guest Update test case according to commit e9cd4666 Use right URI while doing internal redirection Fix test cases to proper get the screenshot and debug report file
src/wok/control/base.py | 4 ++-- src/wok/plugins/kimchi/API.json | 4 ++-- src/wok/plugins/kimchi/control/debugreports.py | 3 ++- src/wok/plugins/kimchi/control/vms.py | 3 ++- src/wok/plugins/kimchi/tests/test_mockmodel.py | 5 +++-- src/wok/plugins/kimchi/tests/test_model.py | 3 --- src/wok/plugins/kimchi/tests/test_rest.py | 12 ++++++------ src/wok/plugins/kimchi/tests/test_template.py | 5 +++-- 8 files changed, 20 insertions(+), 19 deletions(-)