Re: [Kimchi-devel] [PATCH ] Fix screenshots and debug reports paths.
Ming,
Your patch solves only the DebugReports problem, while Leonardo's patch
solves any difference between what UI expects and backend sets.
In addition, IMO the point you mentioned about not expose host file
system to the front is the root cause of this bug. Many UI paths were
broken because the paths set up by backend was not used or followed.
Best regards,
--
Paulo Ricardo Paz Vital <pvital(a)linux.vnet.ibm.com>
IBM Linux Technology Center
On Thu, 2014-02-27 at 10:32 +0800, Shu Ming wrote:
Aline,
I am unhappy about that this patch was merged so quickly. 1) This
patch was initially post on 2/26 23:38 and got merged 2:06AM 2/27, so
people in other timezone didn't get any opportunity to review it. 2)
I post a patch to fix the same problem on 2/26 17:03 that was earlier
than Leonardo's patch. Why did the later patch be merged so quickly and
my patch was left?
As to Leonardo's patch, I don't think we should make every path absolute
and we should use relative path as possible as we can , because we
should not expose host file system to the front user as possible as we can.
2014/2/27 2:06, Aline Manera:
> Applied. Thanks.
>
> Regards,
>
> Aline Manera
>
> _______________________________________________
> Kimchi-devel mailing list
> Kimchi-devel(a)ovirt.org
> http://lists.ovirt.org/mailman/listinfo/kimchi-devel
>
_______________________________________________
Kimchi-devel mailing list
Kimchi-devel(a)ovirt.org
http://lists.ovirt.org/mailman/listinfo/kimchi-devel