On 11/03/2015 06:00, Royce Lv wrote:
On 02/05/2015 12:14 PM, Aline Manera wrote:
On 03/02/2015 06:47, lvroyce@linux.vnet.ibm.com wrote:
From: Royce Lv <lvroyce@linux.vnet.ibm.com>
Feature tests depend on running kimchi server should not be used in model tests, while coincidently, command "qemu-io -r http://localhost:8080/images/icon-fedora.png -c 'read -v 0 512'" return code is 0 so we cannot count on the return code. This patch forces module usage without running kimchi server to return false, and fixes testcase accordingly.
What is the error you are getting when running the tests with the current upstream code?
Reproduced with current upstream code: ====================================================================== FAIL: test_vm_cdrom (test_model.ModelTests) ---------------------------------------------------------------------- Traceback (most recent call last): File "test_model.py", line 539, in test_vm_cdrom self.assertEquals(valid_remote_iso_path, cur_cdrom_path) AssertionError: u'http://fedora.mirrors.tds.net/pub/fedora/releases/20/Live/x86_64/Fedora-Live...' != 'http://204.246.0.137/pub/fedora/releases/20/Live/x86_64/Fedora-Live-Desktop-...'
---------------------------------------------------------------------- Ran 34 tests in 126.156s
please review
Sure. I was just trying to understand the problem. =)
REF: https://github.com/kimchi-project/kimchi/issues/579 https://github.com/kimchi-project/kimchi/issues/580
Those issues seem duplicated for me.
Royce Lv (2): Avoid using server dependent feature tests when server not running Fix wrong usage of feature tests
src/kimchi/model/featuretests.py | 5 ++++- src/kimchi/utils.py | 8 ++++++++ tests/test_model.py | 16 +++++++--------- 3 files changed, 19 insertions(+), 10 deletions(-)