On 8/11/16 12:24 AM, Daniel Henrique Barboza wrote:
Hi Pooja,
I think option (2) is less intrusive and is easier to rollback when/if libvirt for s390x start supporting storage pools. However, isn't it too restrictive? If I understood it right this would mean that the disks would be created always in the default path.
Also, as I said in the other RFC, do not take my word as a 'go ahead' because I am not the official Kimchi maintainer and Aline's opinion may differ from mine.
Default template config file (template.conf) at the moment supports addition of disks via only storage pool. In case of platform s390x, storage pools are not fully supported. By default right now IMG file’s for storage are supported. As per my understanding this option would still valid in case of other platforms too, if user interested in creating IMG file for storage in the specified path. Hence, template config file can have another option which can contain additional parameter called path; # Storage path used to handle the guest IMG files #path = /var/lib/libvirt/images/ Now using of this option can be limited to s390x in the first place. Once it is stabilized and if works well on the other platforms, we can extend this option. From s390x point of view I would recommend the following: a. by default path can be presented from the UI. b. user can provide pool over path if he/she interested in. c. If both options are present path can be can be given priority over the pool. d. In any case we can mandate one option. Regards Chandra
Daniel
On 08/10/2016 03:28 AM, Pooja Kulkarni wrote:
Hi All,
Since currently s390 does not support libvirt storage pools, we propose to provide an additional parameter "path" in disks section to specify the path for a default IMG file to be created in. if "path" attribute is specified, size parameter should be mandatory.
Two possible ways to implement default values, keeping the current option of 'pool' as well: 1. If both path and pool options are found in default config file, path always takes higher precedence over pool irrespective of arch (incase of s390 pool is ignored) 2. Have a different config file if arch is s390 where only default path is found (no pool option).
Let me know what you think.
Regards, Pooja Kulkarni
_______________________________________________ Kimchi-devel mailing list Kimchi-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/kimchi-devel
_______________________________________________ Kimchi-devel mailing list Kimchi-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/kimchi-devel