On 09/11/2014 10:03 PM, CrÃstian Viana wrote:
Most of my feedback from your previous WIP patch still apply. I'll put them here again, along with new comments:
- When the button "OK" is clicked and there is some error (e.g. the URL field is empty, the URL text doesn't start with a correct protocol), the button gets disabled and it never gets enabled again unless the user closes and reopens the dialog. ACK.
- When a download finishes, the progress box doesn't update the message "Downloading...". That message should disappear and the storage volume box should look like the other existing volumes in that pool. ACK.
- Some downloads (e.g. http://distfiles.gentoo.org/releases/amd64/autobuilds/current-stage3-amd64/i...) don't display a progress bar at all. I'll investigate it.
- The correct text when uploading a file should be "Upload a file" (instead of "...an file"). Which part do you mean? It's "Upload a File".
- IMO the submit button's label should be a verb (e.g. "Add") instead of "OK". ACK.
- IMO the menu item "Add Volume" should be the first element on the menu. I just put it alongside with "Extend".
On 10-09-2014 09:02, Hongliang Wang wrote:
Implemented download remote image feature.
Seems something wrong with /tasks response. The "message" is always "OK" and I can't retrieve the progress information.
Dependancies: * [PATCH] storagevolume: Use default value for param 'name' when appropriate
Hongliang Wang (4): Download Remote Image UI: Add Common API to kimchi.api.js Download Remote Image UI: Add Corresponding Window Download Remote Image UI: Updated i18n Strings Download Remote Image UI: Implemented the Feature
ui/css/theme-default/storage.css | 31 ++++++- ui/css/theme-default/storagepool-add-volume.css | 36 ++++++++ ui/js/src/kimchi.api.js | 49 +++++++++++ ui/js/src/kimchi.storage_main.js | 77 +++++++++++++++-- ui/js/src/kimchi.storagepool_add_volume_main.js | 110 ++++++++++++++++++++++++ ui/pages/i18n.json.tmpl | 3 + ui/pages/storagepool-add-volume.html.tmpl | 80 +++++++++++++++++ ui/pages/tabs/storage.html.tmpl | 12 ++- 8 files changed, 388 insertions(+), 10 deletions(-) create mode 100644 ui/css/theme-default/storagepool-add-volume.css create mode 100644 ui/js/src/kimchi.storagepool_add_volume_main.js create mode 100644 ui/pages/storagepool-add-volume.html.tmpl