Reviewed-by: Daniel Barboza <dhbarboza82@gmail.com> On 12/30/2014 11:24 AM, CrÃstian Viana wrote:
This is the first patchset which fixes the issue #544. After applying these patches, the user can now download image files to a logical storage pool. However, they cannot create a template with it because (1) the UI filters the storage volumes and only displays the ones with format='iso' and storage volumes stored in a logical pool always have format='raw', and (2) the template classes fail to identify logical volumes as files because they're symlinks.
Editing an existing VM's XML to use the storage volume downloaded to a logical pool works, though.
CrÃstian Viana (3): Change "_get_storagevolume" to static Use 'bytes' as volume capacity and allocation unit issue #544: Refactor storage volume download
docs/API.md | 4 +- src/kimchi/model/storagevolumes.py | 75 +++++++++++++++++++++++++++++++------- tests/test_model.py | 19 +++++----- tests/test_rest.py | 12 +++--- 4 files changed, 78 insertions(+), 32 deletions(-)