Re: [Kimchi-devel] [PATCH 3/3] Add disks to LVM pool: mockmodel changes

On 02/10/2014 12:51 PM, Aline Manera wrote: > On 02/07/2014 10:53 AM, Daniel Barboza wrote: >> From: Daniel Henrique Barboza <danielhb(a)linux.vnet.ibm.com&gt; >> >> Signed-off-by: Daniel Henrique Barboza <danielhb(a)linux.vnet.ibm.com&gt; >> --- >> src/kimchi/mockmodel.py | 12 ++++++------ >> 1 file changed, 6 insertions(+), 6 deletions(-) >> >> diff --git a/src/kimchi/mockmodel.py b/src/kimchi/mockmodel.py >> index 4e276eb..5303bda 100644 >> --- a/src/kimchi/mockmodel.py >> +++ b/src/kimchi/mockmodel.py >> @@ -316,12 +316,12 @@ class MockModel(object): >> return storagepool.info >> >> def storagepool_update(self, name, params): >> - autostart = params['autostart'] >> - if autostart not in [True, False]: >> - raise InvalidOperation("Autostart flag must be true or >> false") >> - storagepool = self._get_storagepool(name) >> - storagepool.info['autostart'] = autostart >> - ident = storagepool.name >> + pool = self._get_storagepool(name) >> + if 'autostart' in params: >> + if params['autostart'] not in [True, False]: >> + raise InvalidOperation("Autostart flag must be true >> or false") >> + pool.info['autostart'] = params['autostart'] >> + ident = pool.name > > What about the 'disks' for logical pool? > I'm not sure what to do with the disks in the mock model. Sum a fixed amount in the capacity of the pool perhaps?

>> return ident >> >> def storagepool_activate(self, name): >