On 07/01/2014 11:49 PM, Aline Manera wrote:
Welcome to Kimchi, Dinar! :-) It is always a pleasure to see new faces around here.
My comments below:
On 06/30/2014 01:40 PM, Dinar valeev wrote:
From: Dinar Valeev <dvaleev@suse.com>
Add SLES 12 information and set openSUSE's version to 13.1
Signed-off-by: Dinar Valeev <dvaleev@suse.com> --- src/kimchi/isoinfo.py | 1 + src/kimchi/osinfo.py | 9 ++++++--- 2 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/src/kimchi/isoinfo.py b/src/kimchi/isoinfo.py index b7315e0..c394a32 100644 --- a/src/kimchi/isoinfo.py +++ b/src/kimchi/isoinfo.py @@ -95,6 +95,7 @@ iso_dir = [ '|HRM_CENA_X64CHKV|HRM_CPRA_X64FREV|HRM_CPRNA_X64FREV')), ('sles', '10', 'SLES10|SUSE-Linux-Enterprise-Server.001'), ('sles', '11', 'SUSE_SLES-11-0-0'), + ('sles', '12', 'SLE-12'), ('sles', lambda m: "11sp%s" % m.group(1), 'SLES-11-SP(\d+)'), ('opensuse', lambda m: m.group(1), 'openSUSE[ -](\d+\.\d+)'), ('opensuse', '11.1', 'SU1110.001'), diff --git a/src/kimchi/osinfo.py b/src/kimchi/osinfo.py index 093feca..9e8b62e 100644 --- a/src/kimchi/osinfo.py +++ b/src/kimchi/osinfo.py @@ -57,10 +57,13 @@ template_specs = {'x86': {'old': dict(common_spec, disk_bus='ide',
modern_version_bases = {'x86': {'debian': '6.0', 'ubuntu': '7.10', - 'opensuse': '10.3', 'centos': '5.3', - 'rhel': '6.0', 'fedora': '16', 'gentoo': '0'}, + 'opensuse': '13.1', 'centos': '5.3', + 'rhel': '6.0', 'fedora': '16', 'gentoo': '0', + 'sles': '12'}, 'power': {'rhel': '7.0', 'fedora': '19', - 'ubuntu': '14.04'}} + 'ubuntu': '14.04', + 'opensuse': '13.1', + 'sles': '12'}}
icon_available_distros = [icon[5:-4] for icon in glob.glob1('%s/images/' % paths.ui_dir, 'icon-*.png')]
The modern_version_bases dict tells Kimchi from whichi OS version it can use virtio bus. You can see more details in src/kimchi/osinfo.py:116
if distro in modern_version_bases[arch]: if LooseVersion(version) >= LooseVersion( modern_version_bases[arch][distro]): params.update(template_specs[arch]['modern']) else: params.update(template_specs[arch]['old'])
So your patch should not change the opensuse version for x86
And for power, you need to add the lowest version that supports virtio bus. I know Ubuntu 14.04 is the first Ubuntu version supported for Power so it is correct But is it true for opensuse 13.1 and sles 12?