This solution works for Kimchi and Ginger now, but I analyzed it a bit deeper and I cannot see it as a good long-term solution. Reasons: - other plugins will never be allowed to have a column named version in its table, for whatever reason they want; - every new record must have the version inserted, today we cannot measure the impact, but, if for some reason objectstore must be heavily used, this can impact; - we will have (or each plugin will have) to change this in future, because all 'object' tables will have 'version' column, then each plugin will have to manage by itself how to check and update the records or schemas; - finally, I think that Wok should not touch plugins 'objectstore'. Like I said, this solution works for Kimchi/Ginger now, and I am ok, once we are running out of time. But keep in mind , that we are going to have rework in future. Aline can decide what to do. Reviewed-by: Rodrigo Trujillo <rodrigo.trujillo@linux.vnet.ibm.com> On 12/14/2015 11:46 AM, pvital@linux.vnet.ibm.com wrote:
From: Paulo Vital <pvital@linux.vnet.ibm.com>
This patch is part of the solution for the Ginger Issue #51 and it depends on Wok's "Upgrade objectstore schema" patch.
With the new structure of the objectstore changed in Wok 2.0.0, the schema of the objectstore file needs to be checked and, if necessary, updated to reflect the new structure.
This patch removes from Kimchi the methods used to check the objectstore schema and upgrade it if necessary. These methods are now present in wok.plugins and are common to any Wok plugin.
Paulo Vital (1): Update Kimchi objectstore versioning.
root.py | 4 ++-- utils.py | 40 ---------------------------------------- 2 files changed, 2 insertions(+), 42 deletions(-)
-- 2.5.0
_______________________________________________ Kimchi-devel mailing list Kimchi-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/kimchi-devel