Re: [Kimchi-devel] [PATCH 0/4] UI: Download Remote Image Feature

Some comments: 1. The "Add volume" option must be available only for active pools.

2. The "Add volume" option is not allowed for iscsi and scsi storage pools.

3. Disable upload option as this patch set only cares about download.

4. When the download completes, the storage volume box should be updated to remove the progress bar

On 09/10/2014 09:02 AM, Hongliang Wang wrote: > Implemented download remote image feature. > > Seems something wrong with /tasks response. The "message" is > always "OK" and > I can't retrieve the progress information. > > Dependancies: > * [PATCH] storagevolume: Use default value for param 'name' when > appropriate > > Hongliang Wang (4): > Download Remote Image UI: Add Common API to kimchi.api.js > Download Remote Image UI: Add Corresponding Window > Download Remote Image UI: Updated i18n Strings > Download Remote Image UI: Implemented the Feature > > ui/css/theme-default/storage.css | 31 ++++++- > ui/css/theme-default/storagepool-add-volume.css | 36 ++++++++ > ui/js/src/kimchi.api.js | 49 +++++++++++ > ui/js/src/kimchi.storage_main.js | 77 > +++++++++++++++-- > ui/js/src/kimchi.storagepool_add_volume_main.js | 110 > ++++++++++++++++++++++++ > ui/pages/i18n.json.tmpl | 3 + > ui/pages/storagepool-add-volume.html.tmpl | 80 > +++++++++++++++++ > ui/pages/tabs/storage.html.tmpl | 12 ++- > 8 files changed, 388 insertions(+), 10 deletions(-) > create mode 100644 ui/css/theme-default/storagepool-add-volume.css > create mode 100644 ui/js/src/kimchi.storagepool_add_volume_main.js > create mode 100644 ui/pages/storagepool-add-volume.html.tmpl >