Re: [Kimchi-devel] [PATCH v2 0/2] Improve VCPU code
Hi,
like I wrote in "[Kimchi-devel] [PATCH v3 0/5] Improve VM CPU update
code ", I think that
this patch set should be merged with it. Then, we do not have a broken
patch set and a fix patch set.
Rodrigo Trujillo
On 09/16/2015 04:02 PM, Jose Ricardo Ziviani wrote:
v2:
- patch rebased
*IMPORTANT*: This patch depends on cpu hotplug support.
This patchset addresses two issues regarding vcpu:
1 - users cannot update the number of cpus when topology is defined. In
such case, vcpu must always be sockets * cores * threads. If a VM has a
topology defined and we try to simply change vcpu without taking care of
that topology libvirt will complain.
NOTE: Using Kimchi UI, we can define the topology only when creating a
template, it means that thoses values cannot be updated because there is
no interface to do that.
2 - the maximum vcpu returned by libvirt is wrong. In Power it returns
1024 however the VM won't even boot with that value.
Jose Ricardo Ziviani (2):
Forbid user to edit CPU value if topology is defined
Do not use libvirt to retrieve max vcpu value
src/kimchi/i18n.py | 1 +
src/kimchi/model/vms.py | 29 ++++++++++++++++++++++++++++-
2 files changed, 29 insertions(+), 1 deletion(-)