6:34 p.m.
The notebook looks nice, but I worry that someone may not expect the CDROM
change to take effect until they press the save button on the General tab.
By the same token I worry that others might expect the change to take
effect immediately.
Should we handle attaching and detaching CDROMs to a running guest?
Are there other devices we expect to be able to attach and detach such as
USB devices? Others?
Maybe we should consider adding a new action for managing devices, or do we
think we'll eventually be able to change everything about a VM while its
running:
CPUs
Memory
Networks
storage
CDROMS
other...
While I am asking questions, should it be DVD ROMs?How long until its
Blueray ROMs? :-)
On 03/04/2014 04:01 AM, Hongliang Wang wrote:
Allow user to manipulate CDROM(s) in a VM:
1) Attach one or more CDROM(s);
2) Replace a CDROM with another ISO file path;
3) Detach a CDROM from a VM.
Tested on Chrome.
Please apply the following patch first:
* [UI] Window - Correct Footer Height
v1 -> v2:
2a) Separate one patch into 4 small ones to make it easier to review
(Thanks to Ramon Medeiros's comment)
2b) Updated API calling to list CDROM
(Thanks to Aline's comment)
2c) Separated VM updating window into 2 parts: general and storage
(Thanks to Aline's comment)
2d) Enhanced UI to allow user trigger replace CDROM window by clicking
ISO file path text box
2e) Changed uneditable fields from readonly to disabled
2f) Removed authors infomation
(Thanks to Aline's comment)
Hongliang Wang (4):
[UI] Add CDROM-related APIs
[UI] Add i18n Variables for CDROM-related Function
[UI] Add/Edit CDROM Support
[UI] Attach/Replace/Detach a CDROM to/in/from a VM
ui/css/theme-default/guest-cdrom-add.css | 62 +++++++++++
ui/css/theme-default/guest-cdrom-edit.css | 62 +++++++++++
ui/css/theme-default/guest-edit.css | 108 +++++++++++++++---
ui/images/theme-default/guest-icon-sprite.png | Bin 0 -> 6748 bytes
ui/js/src/kimchi.api.js | 74 +++++++++++++
ui/js/src/kimchi.guest_cdrom_add_main.js | 79 +++++++++++++
ui/js/src/kimchi.guest_cdrom_edit_main.js | 87 +++++++++++++++
ui/js/src/kimchi.guest_edit_main.js | 75 ++++++++++++-
ui/pages/guest-cdrom-add.html.tmpl | 73 ++++++++++++
ui/pages/guest-cdrom-edit.html.tmpl | 73 ++++++++++++
ui/pages/guest-edit.html.tmpl | 153 +++++++++++++++++---------
ui/pages/i18n.html.tmpl | 5 +
12 files changed, 778 insertions(+), 73 deletions(-)
create mode 100644 ui/css/theme-default/guest-cdrom-add.css
create mode 100644 ui/css/theme-default/guest-cdrom-edit.css
create mode 100644 ui/images/theme-default/guest-icon-sprite.png
create mode 100644 ui/js/src/kimchi.guest_cdrom_add_main.js
create mode 100644 ui/js/src/kimchi.guest_cdrom_edit_main.js
create mode 100644 ui/pages/guest-cdrom-add.html.tmpl
create mode 100644 ui/pages/guest-cdrom-edit.html.tmpl
--
Adam King <rak(a)linux.vnet.ibm.com>
IBM CSI