"make check-local" returns a few errors: ./src/kimchi/vmtemplate.py:287:80: E501 line too long (99 > 79 characters) ./src/kimchi/model/vms.py:217:31: E711 comparison to None should be 'if cond is not None:' ./src/kimchi/model/vms.py:686:25: E128 continuation line under-indented for visual indent ./src/kimchi/model/vms.py:926:80: E501 line too long (80 > 79 characters) ./src/kimchi/model/vms.py:951:80: E501 line too long (81 > 79 characters) ./src/kimchi/model/vms.py:957:5: E303 too many blank lines (2) And "sudo make check" also reports a new test failure: ====================================================================== FAIL: test_vm_lifecycle (test_rest.RestTests) ---------------------------------------------------------------------- Traceback (most recent call last): File "test_rest.py", line 307, in test_vm_lifecycle self.assertEquals(200, resp.status) AssertionError: 200 != 404 ---------------------------------------------------------------------- Please run "make check-local" and "sudo make check" to make sure new patches don't break the application. On 07-05-2015 14:40, Ramon Medeiros wrote:
Libvirt does not support special characters on name tag. This patch make Kimchi writes the special name at title tag and use an ascii version in name tag.
Ramon Medeiros (9): Create title tag Change the way that get_vm() and vm_list() search for VMs Use get_vm() instead of conn.lookupByName Encode vm_name to generate VNC token Reflect the unicode conversion on token creation Redefine title tag on vm update Fix functions that uses connection as parameter Return name with special characters when taking snapshot Template_test: check assert that verifies the vm name
src/kimchi/model/vms.py | 82 +++++++++++++++++++++++++++++++++++------ src/kimchi/model/vmsnapshots.py | 7 ++++ src/kimchi/model/vmstorages.py | 7 +--- src/kimchi/vmtemplate.py | 4 +- tests/test_vmtemplate.py | 8 +++- ui/js/src/kimchi.api.js | 4 +- 6 files changed, 92 insertions(+), 20 deletions(-)