Reviewed-By: Lucio Correia <luciojhc@linux.vnet.ibm.com> On 01/11/2016 11:09, dhbarboza82@gmail.com wrote:
From: Daniel Henrique Barboza <danielhb@linux.vnet.ibm.com>
This patch changes contrib/kimchi.spec.fedora.in and contrib/kimchi.spec.suse.in to comply with the rpm guidelines enforced by the rpmlint tool.
After this patch, running check-local or ././check_spec_errors.sh gives only these warnings:
contrib/kimchi_fedora.spec: W: invalid-url Source0: kimchi-2.3.0.tar.gz 0 packages and 1 specfiles checked; 0 errors, 1 warnings. contrib/kimchi_suse.spec: W: invalid-url Source0: kimchi-2.3.0.tar.gz 0 packages and 1 specfiles checked; 0 errors, 1 warnings.
According to https://bugzilla.redhat.com/show_bug.cgi?id=566978 it is safe to ignore the 'invalid-url Source0' warning.
Signed-off-by: Daniel Henrique Barboza <danielhb@linux.vnet.ibm.com> --- contrib/kimchi.spec.fedora.in | 4 ++-- contrib/kimchi.spec.suse.in | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/contrib/kimchi.spec.fedora.in b/contrib/kimchi.spec.fedora.in index 29d4463..3b33297 100644 --- a/contrib/kimchi.spec.fedora.in +++ b/contrib/kimchi.spec.fedora.in @@ -46,7 +46,7 @@ Requires: spice-html5 %if 0%{?rhel} == 6 Requires: python-ordereddict Requires: python-imaging -BuildRequires: python-unittest2 +BuildRequires: python-unittest2 %endif
%description @@ -54,7 +54,7 @@ Web application to manage KVM/Qemu virtual machines
%prep -%setup +%setup -q
%build diff --git a/contrib/kimchi.spec.suse.in b/contrib/kimchi.spec.suse.in index 3d0896b..94dc55e 100644 --- a/contrib/kimchi.spec.suse.in +++ b/contrib/kimchi.spec.suse.in @@ -36,7 +36,7 @@ BuildRequires: libxslt-tools BuildRequires: python-lxml
%if 0%{?suse_version} == 1100 -Requires: python-ordereddict +Requires: python-ordereddict %endif
%if 0%{?suse_version} > 1140 @@ -47,7 +47,7 @@ Requires: python-ordereddict Web application to manage KVM/Qemu virtual machines
%prep -%setup +%setup -q
%build %configure --with-spice-html5
-- Lucio Correia Software Engineer IBM LTC Brazil