Hi Ziviani, some considerations: This patch set has some runtime problems, which you fix in your previous patch set: [Kimchi-devel] [PATCH v2 0/2] Improve VCPU code I am against of commit this patch set and then commit another over it, to fix the problems. I would like to propose to you to merge both patch sets and separate in less commits. Will be better to review and test. Rodrigo Trujillo On 09/16/2015 03:51 PM, Jose Ricardo Ziviani wrote:
v3: - included commit "Hot add/remove CPUs on PPC"
v2: - patch rebased
This patchset refactors part of the code related to updating VM CPUs.
I am aware of two tests which are failing with this patchset. They'll be worked on before the final version.
Crístian Deives (4): Use locks to prevent concurrent updates to VMs Update VCPU by using libvirt function Set max VCPU count to the max supported value Check if the VM update params are valid for the current state
Crístian Viana (1): Hot add/remove CPUs on PPC
src/kimchi/i18n.py | 5 +++ src/kimchi/mockmodel.py | 48 ++++++++-------------- src/kimchi/model/vms.py | 106 ++++++++++++++++++++++++++++++++++++++++++++---- tests/test_rest.py | 3 +- 4 files changed, 122 insertions(+), 40 deletions(-)