On 11-08-2014 12:38, shaohef@linux.vnet.ibm.com wrote:
From: ShaoHe Feng <shaohef@linux.vnet.ibm.com>
After set the password, only the one knows the password can access the vm graphic.
Signed-off-by: ShaoHe Feng <shaohef@linux.vnet.ibm.com> Signed-off-by: Simon Jin <simonjin@linux.vnet.ibm.com>
- A user can't tell what this password is about by using Kimchi. It just displays "Password". Password for what? *I* know it's related to VNC access because I read it here on your patch's description, but an end user won't be able to know. - Use a consistent form style to display the text fields. As we still don't use a universal style, at least be consistent inside the same dialog. The tab "General" has labels and text fields on the same line, aligned to the left of the dialog. The tab "Password" has labels and text fields on different lines, they're not centered or aligned at all to the dialog. - Use a consistent error message. Kimchi has a standard JavaScript function call to display error messages (kimchi.message.error), let's not use yet another way of displaying error messages. - What's the purpose of the "Save" button initial state as invisible? If it's to prevent the user to set an empty password, that's not happening. When the user types something on both text fields, the button becomes visible. Then if the user removes the text they typed, the button still keeps visible. An empty password can be set now. And even if the user doesn't type anything at all and just presses the Tab key twice, the button also becomes visible. An empty password can also be set this way. We still don't use a consistent input data handling across all dialogs in Kimchi, but this approach doesn't validate the input data correctly.