Reviewed-by: Daniel Barboza <danielhb@linux.vnet.ibm.com> ps: do you mind explaining exactly why the line "data[field] = $('#form-guest-edit [name="' + field + '"]').val(); " Doesn't work? I failed to see why it is causing a bug. On 04/10/2014 05:27 AM, Hongliang Wang wrote:
When changing a guest name in Guest Tab, the change takes no effect because of a UI bug. Fix it in this patch.
Signed-off-by: Hongliang Wang <hlwang@linux.vnet.ibm.com> --- ui/js/src/kimchi.guest_edit_main.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ui/js/src/kimchi.guest_edit_main.js b/ui/js/src/kimchi.guest_edit_main.js index 9375c51..b771263 100644 --- a/ui/js/src/kimchi.guest_edit_main.js +++ b/ui/js/src/kimchi.guest_edit_main.js @@ -119,7 +119,7 @@ kimchi.guest_edit_main = function() { var editableFields = [ 'name' ]; var data = {}; $.each(editableFields, function(i, field) { - data[field] = $('#form-guest-edit [name="' + field + '"]').val(); + data[field] = $('input[name="' + field + '"]', guestEditForm).val(); }); kimchi.updateVM(kimchi.selectedGuest, data, function() { kimchi.listVmsAuto();