Re: [Kimchi-devel] [PATCH v2] [Kimchi] Create new volume and attach to VM
Hi Socorro,
Just 2 comments:
- When listing the storage pools, please, do not display 'kimchi_isos'
as it is exclusive for Kimchi proposals and user should not be aware
about it
- Set the default format as qcow2. It is displaying 'bochs' because of
the alphabetic order, I think.
Regards,
Aline Manera
On 02/05/2016 02:14 PM, Socorro Stoppler wrote:
V2:
Add ".img" to name of new volume being created
V1:
This is the initial checkin for creating a new volume and attaching to VM when editing
a guest. Not sure of all the supported cases, but tried default pool and qcow2 format
per the example provided in the back-end patch and it was successful.
Known issue - which currently exists in the code already in master - code is broken when
VM
is running. This patch does not address that. It will get addressed separately.
Socorro Stoppler (1):
Create new volume and attach to VM
Add ".img" to name of new volume
ui/js/src/kimchi.guest_storage_add.main.js | 320 ++++++++++++++++++++++++-----
ui/pages/guest-storage-add.html.tmpl | 58 ++++--
2 files changed, 315 insertions(+), 63 deletions(-)