Re: [Kimchi-devel] [PATCH 0/4] [UI] Host Repositories Management Support

On 03/07/2014 05:26 PM, Adam King wrote: > > On 3/7/2014 3:09 PM, Aline Manera wrote: >> On 03/06/2014 06:44 AM, Hongliang Wang wrote: >>> On 03/05/2014 03:53 AM, Adam King wrote: >>>> A few interface suggestions: >>>> >>>> Repositories table: >>>> Remove "Repos" string from column headers. It should be obvious >>>> this data relates to repositories from the section title >>> ACK >>>> Remove numerical column, making the ID column non-scrollable >>> It's used to tell user how many packages in total and when user is >>> scrolling, which line he is at. It's intentionally made >>> non-scrollable as "frozen column", just as the non-scrollable first >>> row, which is the header of the table. >>> >>> Though in the future, we need enhance the Grid Widget with a >>> status bar to show total information and at that time, I think we >>> can remove the ID column. >>>> Combine Base URL and args into a single URL. >>> I was trying to combine them, though found seems base URL is >>> already with args. What's the meaning of URL args? Is there any >>> sample? I'm confused here. @Aline >>> >>> Base URL example: >>> https://mirrors.fedoraproject.org/metalink?repo=fedora-18&arch=x86_64 >>>> Show full URLs onHover or via some gesture >>> In fact, you can resize the columns to see full URLs, >>>> Reorder columns as follows. Column names & order would be: >>>> ID, Name, Enabled, URL, Mirror, GPG Check, GPG Key >>> ACK if it's confirmed. >>>> >>>> >>>> Edit window: >>>> Make edit window field names match column names with the possible >>>> exception of combining URL and Args >>> ACK >>>> Enable the radio buttons for enabled, mirror >>> I did do that, but back-end APIs refused to update these 2 fields, >>> so I disabled them. Need discussions. @Aline >> >> From the API.md the is_mirror parameter can be updated. >> @Paulo more info on that? >> >>>> Will we ever want a value in GPG key, but GPG check disabled? If >>>> not, combine the 2 fields such that specifying a key implies they >>>> key should be checked, and vice versa. >>> Makes sense. @Aline >> >> Yes. > Would you elaborate on when it would be desirable to maintain a key > that we don't check? Yes, it makes sense for me. =) I've just agreed with your suggestion

>> >>>> >>>> Add a Repository window: >>>> If it ever makes sense to have GPG Check false, but GPG Key filled >>>> then we need to add the "Check" boolean to this window >>> Yes. Need clearer API definition. >>> @Aline >> >> The input field for GPG key can be triggered by the check box "GPG >> Check" >> If user select the GPG Check we enable the GPG key input and make it >> a required field. >> >> Makes sense? > It would make more sense to assume that the user wants the key > checked if they provide one, and don't want it checked if they don't. ok >> >>>> Can we determine if the URL is a mirror programatically? If so we >>>> should. >> >> Not sure. >> @Paulo >> >>>> Why is "Base URL" the only required field? When I submit a new >>>> repo with an invalid URL, nothing appears to happen. >>> I checked REST API and found it's the only required field. Seems we >>> can add a invalid repos URL through shell, too. >>> @Aline >> >> Yes. It is the only required field for a repo. >> Maybe backend is missing a URL validation for properly display the >> error > I don't understand. If the URL is the only required field, why does > it cause an error when only the URL field is supplied? Which error you got when trying it?

>> >>>> When I submit one with only a valid URL, a number of fields are >>>> subsequently displayed as null. >>>> The dynamically generated ID and Name could be friendlier. >>> @Aline >>>> >>>> >>>> >>>> On 03/04/2014 05:33 AM, Hongliang Wang wrote: >>>>> Add host repositories management in this patch set. >>>>> >>>>> Hongliang Wang (4): >>>>> [UI] Add i18n Strings for Repositories Management >>>>> [UI] Add API Support for Repositories Management >>>>> [UI] Add/Edit Repository Support >>>>> [UI] Integrate Repositories Management into Host Tab >>>>> >>>>> po/POTFILES.in | 2 + >>>>> ui/css/theme-default/host.css | 44 +++++++++++ >>>>> ui/css/theme-default/repository-add.css | 39 ++++++++++ >>>>> ui/css/theme-default/repository-edit.css | 69 +++++++++++++++++ >>>>> ui/js/src/kimchi.api.js | 61 +++++++++++++++ >>>>> ui/js/src/kimchi.host.js | 126 >>>>> +++++++++++++++++++++++++++++++ >>>>> ui/js/src/kimchi.repository_add_main.js | 84 >>>>> +++++++++++++++++++++ >>>>> ui/js/src/kimchi.repository_edit_main.js | 85 >>>>> +++++++++++++++++++++ >>>>> ui/pages/i18n.html.tmpl | 18 +++++ >>>>> ui/pages/repository-add.html.tmpl | 104 >>>>> +++++++++++++++++++++++++ >>>>> ui/pages/repository-edit.html.tmpl | 121 >>>>> +++++++++++++++++++++++++++++ >>>>> ui/pages/tabs/host.html.tmpl | 13 ++++ >>>>> 12 files changed, 766 insertions(+) >>>>> create mode 100644 ui/css/theme-default/repository-add.css >>>>> create mode 100644 ui/css/theme-default/repository-edit.css >>>>> create mode 100644 ui/js/src/kimchi.repository_add_main.js >>>>> create mode 100644 ui/js/src/kimchi.repository_edit_main.js >>>>> create mode 100644 ui/pages/repository-add.html.tmpl >>>>> create mode 100644 ui/pages/repository-edit.html.tmpl >>>>> >>>> >>>> >>> >>> _______________________________________________ >>> Kimchi-devel mailing list >>> Kimchi-devel(a)ovirt.org >>> http://lists.ovirt.org/mailman/listinfo/kimchi-devel >>> >> >