Re: [Kimchi-devel] [PATCHv2 0/5] Create vm from image based template

On 2014年07月17日 08:30, Aline Manera wrote: > > On 07/15/2014 06:11 AM, lvroyce(a)linux.vnet.ibm.com wrote: >> From: Royce Lv <lvroyce(a)linux.vnet.ibm.com&gt; >> >> How to test: >> create a image using: >> POST /templates {'name':'mytemp', 'disks':[{'base':'a_base_img_path'}]} >> create a vm using: >> POST /vms {'template': '/templates/mytemp', 'pool'....} >> >> Known issues: >> 1.This is only available for NFS and dir pool > > Could you explain the problems with other storage pools? (iscsi, > scsi, logical) OK, I will update commit msg later. > >> 2.template integrity is not checked, and base img is not protected. > > For template integrity, verify the base img is accessible by qemu ACK > > Do you mean about protecting the base img? Yes

> >> 3.Welcome ideas on how to test this feature. > > You can use dd or qemu-img to create a img and from that do the rest > and model tests > and after that delete the img you created for the tests Since we probed image info dd and qemu-img does not fit this case.

> >> >> Royce Lv (5): >> Add image probe function >> Change doc and api specification >> Change 'cdrom' to a optional param >> Integrate image os probe in vm template create >> Create volume based on backing store image >> >> docs/API.md | 3 ++- >> docs/README.md | 9 ++++--- >> src/kimchi/API.json | 8 +++++- >> src/kimchi/control/templates.py | 2 +- >> src/kimchi/exception.py | 4 +++ >> src/kimchi/i18n.py | 8 +++++- >> src/kimchi/imageinfo.py | 48 +++++++++++++++++++++++++++++++++ >> src/kimchi/mockmodel.py | 27 ++++++++++++++----- >> src/kimchi/model/templates.py | 13 +++++---- >> src/kimchi/model/vms.py | 1 + >> src/kimchi/utils.py | 16 +++++++++++ >> src/kimchi/vmtemplate.py | 60 +++++++++++++++++++++++++++-------------- >> tests/test_rest.py | 2 +- >> 13 files changed, 162 insertions(+), 39 deletions(-) >> create mode 100644 src/kimchi/imageinfo.py >> >