Just a minor inline comment below On 06/25/2014 03:00 AM, Christy Perez wrote:
index 43484f5..f64b879 100644 --- a/ui/js/src/kimchi.report_add_main.js +++ b/ui/js/src/kimchi.report_add_main.js @@ -41,7 +41,7 @@ kimchi.report_add_main = function() { return false; } var reportName = nameTextbox.val(); - var validator = RegExp("^[A-Za-z0-9-]*$"); + var validator = RegExp("^[_A-Za-z0-9-]*$");
What about other characters? dose kimchi allow non ascii characters? it means do we allow Chinese name "我的报告"? but a pure word and underscore is OK for me. here you can use "w" for RE. [-w] means [_A-Za-z0-9-]. also here you allow the report name is empty, Does that means let kimchi generate a name for the report?
if (!validator.test(reportName)) { kimchi.message.error.code('KCHDR6011M'); return false;
-- Thanks and best regards! Sheldon Feng(冯少合)<shaohef@linux.vnet.ibm.com> IBM Linux Technology Center