Re: [Kimchi-devel] [RFC] Changes to "disks" attribute of template creation API to support s390 architecture
Hi Pooja,
I think option (2) is less intrusive and is easier to rollback when/if
libvirt for s390x
start supporting storage pools. However, isn't it too restrictive? If I
understood it
right this would mean that the disks would be created always in the
default path.
Also, as I said in the other RFC, do not take my word as a 'go ahead'
because I am
not the official Kimchi maintainer and Aline's opinion may differ from mine.
Daniel
On 08/10/2016 03:28 AM, Pooja Kulkarni wrote:
Hi All,
Since currently s390 does not support libvirt storage pools, we
propose to provide an additional parameter "path" in disks section to
specify the path for a default IMG file to be created in. if "path"
attribute is specified, size parameter should be mandatory.
Two possible ways to implement default values, keeping the current
option of 'pool' as well:
1. If both path and pool options are found in default config file,
path always takes higher precedence over pool irrespective of arch
(incase of s390 pool is ignored)
2. Have a different config file if arch is s390 where only default
path is found (no pool option).
Let me know what you think.
Regards,
Pooja Kulkarni
_______________________________________________
Kimchi-devel mailing list
Kimchi-devel(a)ovirt.org
http://lists.ovirt.org/mailman/listinfo/kimchi-devel