My vote is for option 2 too On 04/08/2014 12:57 PM, Adam King wrote:
I would recommend option 2: "shutdown" and "power off"
On 4/8/2014 11:21 AM, Sheldon wrote:
Currently, stopping guests in Kimchi is not graceful in the sense that the guest becomes 'shut down' immediately. This could be be problematic because guest file systems could become corrupted. Perhaps a warning should be added before a guest is immediately stopped or reset.
kimchi can does not support shutdown by agent, so we can not guarantee we can shutdown graceful. User should install agent manully
We can use acpi shutdown a VM. But not all guest os will shutdown the VM even it receive acpi shutdown.
So I have 2 proposal:
1. only one shutdown API and one shutdown button for UI. when user click shutdown, the backend will try to shutdown VM by acpi. if 1 minutes timeout, kimchi will destroy the VM forcefully.
2. support ACPI shutdown and destroy two APIs. support "force off" and "shutdown" 2 buttons in UI. "shutdown" means ACPI shutdown. but we can not guarantee it can shutdown the VM. If the user find the VM is not shutdown for some time, he can try to force power off the VM