Good point to keep consistent! And be aware of that the confirmation dialog still has "Cancel" Button with "X" button at the right top corner. For that case, seems putting "OK" and "Cancel" Buttons at the same line is a good choice. I'll send a patch for confirmation dialog to remove "X" button. Thanks for the suggestion! This patch is only meant to update the modal
On 15-05-2014 00:12, Hongliang Wang wrote: dialogs (create, edit, etc), not the confirmation dialogs. I'm planning on sending a different patchset to keep the messages and buttons on the confirmation dialogs consistent as well. Some confirmation popups have "Confirm" / "Cancel", some have "OK" / "Cancel"; some popups don't even have a question (e.g. "This operation can damage your VM. OK / Cancel"). And I agree that the buttons "OK" and "Cancel" look good on the confirmation dialogs, and we should keep them there - well, they could also look nice on the modal dialogs as long as every dialog had them consistently. I'm looking forward to review your patch which will remove the "X" button from the confirmation dialogs :-)