Re: [Kimchi-devel] [PATCH] [Kimchi 1/4] CPU Hot plug/unplug: i18n changes
On 11/08/2016 10:33 AM, Lucio Correia wrote:
On 08/11/2016 09:49, dhbarboza82(a)gmail.com wrote:
> From: Daniel Henrique Barboza <danielhb(a)linux.vnet.ibm.com>
>
> This patch adds new i18n messages to be used by the new
> CPU Hotplug backend.
>
> Signed-off-by: Daniel Henrique Barboza <danielhb(a)linux.vnet.ibm.com>
> ---
> i18n.py | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/i18n.py b/i18n.py
> index 03929e5..205e1af 100644
> --- a/i18n.py
> +++ b/i18n.py
> @@ -363,6 +363,11 @@ messages = {
> "KCHCPUINF0008E": _("Parameter 'cpu_info' expects an
object with
> fields among: 'vcpus', 'maxvcpus', 'topology'."),
> "KCHCPUINF0009E": _("Parameter 'topology' expects an
object with
> fields among: 'sockets', 'cores', 'threads'."),
>
> + "KCHCPUHOTP0001E": _("Unable to update Max vCPU or CPU topology
> when guest is running."),
> + "KCHCPUHOTP0002E": _("VM '%(vm)s' cannot have more than
%(cpus)s
> CPUs. Please update the CPU value when the VM is not running or
> increase Max CPU value."),
It would be better to keep the same term (either Max vCPU or Max CPU).
You're right.
I've checked the UI and it is using 'CPU' there. I've changed these
messages
to 'CPU' in the v2.
Thanks!
> + "KCHCPUHOTP0003E": _("Topology set for vm is
> sockets='%(sockets)s', cores='%(cores)s' and
threads='%(threads)s'.
> New CPU value must be a multiple of the threads value (%(threads)s)."),
> + "KCHCPUHOTP0004E": _("Unable to hot plug/unplug CPUs. Details:
> %(err)s"),
> +
> "KCHLVMS0001E": _("Invalid volume group name parameter:
> %(name)s."),
>
> "KCHCONN0001E": _("Unable to establish connection with libvirt.
> Please check your libvirt URI which is often defined in
> /etc/libvirt/libvirt.conf"),
>