Re: [Kimchi-devel] About the pre-integration test
on 2014/01/15 16:05, Shu Ming wrote:
Hi,
After running the full unit-test cases by "sudo ./run_test.sh", I found
the test cases were broken in all platforms including Fedora 20, Fedora
18, Ubuntu 12.04. I am not sure which patch broke it, but I think we
should make sure all the existing unit-test cases passed before
integration.
To the maintainer, please enforce it when merging the patches. To the
patch's submitter, please do a full unit test before submitting your
patches into the mailing lists. It is very common for a new patch to
trigger other test case's failure which seems non-related. Please make
your code clean by the unit test cases. The unit test cases may take one
minute, but it will save other's time in hours.
I setup an internal Jenkins to run unit tests using root. If there is
any failed tests I can also help reporting them to community. For now
Jenkins says all tests are OK. Maybe you can provide error message of
your failed tests and let's investigate how we can reproduce it.
_______________________________________________
Kimchi-devel mailing list
Kimchi-devel(a)ovirt.org
http://lists.ovirt.org/mailman/listinfo/kimchi-devel
--
Thanks and best regards!
Zhou Zheng Sheng / 周征晟
E-mail: zhshzhou(a)linux.vnet.ibm.com
Telephone: 86-10-82454397