11:50 a.m.
When the user performs some operations (like updating guest CD-ROMs), a green
success message is displayed on top of the screen. This behavior is not common
in Kimchi; when an operation performs successfully, nothing is shown.
In order to make Kimchi more consistent, remove the code that displays
success messages.
This patch enforces what was applied by 57f9f9f.
Signed-off-by: Crístian Viana <vianac(a)linux.vnet.ibm.com>
---
ui/css/theme-default/guest-edit.css | 24 ------------------------
ui/js/src/kimchi.guest_edit_main.js | 7 -------
ui/js/src/kimchi.guest_media_main.js | 3 ---
ui/pages/guest-edit.html.tmpl | 1 -
ui/pages/guest-media.html.tmpl | 3 ---
5 files changed, 38 deletions(-)
diff --git a/ui/css/theme-default/guest-edit.css b/ui/css/theme-default/guest-edit.css
index 43f71c0..0b7ba21 100644
--- a/ui/css/theme-default/guest-edit.css
+++ b/ui/css/theme-default/guest-edit.css
@@ -156,27 +156,3 @@
.guest-edit-cdrom-button.detach[disabled] {
background-position: -54px -108px;
}
-
-#message-container {
- color: #555;
- font-size: 14px;
- height: 100%;
- line-height: 56px;
-}
-
-#message-container .message {
- background: transparent;
-}
-
-#message-container .success {
- color: green;
-}
-
-#message-container .error {
- color: red;
-}
-
-#message-container .content {
- margin: 0;
- position: static;
-}
diff --git a/ui/js/src/kimchi.guest_edit_main.js b/ui/js/src/kimchi.guest_edit_main.js
index 5ec5459..9375c51 100644
--- a/ui/js/src/kimchi.guest_edit_main.js
+++ b/ui/js/src/kimchi.guest_edit_main.js
@@ -91,20 +91,13 @@ kimchi.guest_edit_main = function() {
kimchi.window.open("guest-storage-add.html");
});
- var messageNode = $('#message-container');
var onAttached = function(params) {
- $(messageNode).empty();
- kimchi.message.success(i18n['KCHVMCD6006M'], messageNode);
refreshCDROMs();
};
var onReplaced = function(params) {
- $(messageNode).empty();
- kimchi.message.success(i18n['KCHVMCD6007M'], messageNode);
refreshCDROMs();
};
var onDetached = function(params) {
- $(messageNode).empty();
- kimchi.message.success(i18n['KCHVMCD6008M'], messageNode);
refreshCDROMs();
};
diff --git a/ui/js/src/kimchi.guest_media_main.js b/ui/js/src/kimchi.guest_media_main.js
index 1669646..02009ec 100644
--- a/ui/js/src/kimchi.guest_media_main.js
+++ b/ui/js/src/kimchi.guest_media_main.js
@@ -45,10 +45,7 @@ kimchi.guest_media_main = function() {
refreshCDROMs();
- var messageNode = $('#message-container');
var onReplaced = function(params) {
- $(messageNode).empty();
- kimchi.message.success(i18n['KCHVMCD6007M'], messageNode);
refreshCDROMs();
};
kimchi.topic('kimchi/vmCDROMReplaced').subscribe(onReplaced);
diff --git a/ui/pages/guest-edit.html.tmpl b/ui/pages/guest-edit.html.tmpl
index ba6ba2b..804fc39 100644
--- a/ui/pages/guest-edit.html.tmpl
+++ b/ui/pages/guest-edit.html.tmpl
@@ -111,7 +111,6 @@
<span class="text">$_("Save")</span>
</button>
</div>
- <div id="message-container"></div>
</footer>
</div>
<script id="cdrom-row-tmpl" type="text/html">
diff --git a/ui/pages/guest-media.html.tmpl b/ui/pages/guest-media.html.tmpl
index eb12d72..83ad6ab 100644
--- a/ui/pages/guest-media.html.tmpl
+++ b/ui/pages/guest-media.html.tmpl
@@ -34,9 +34,6 @@
</fieldset>
</form>
</div>
- <footer>
- <div id="message-container"></div>
- </footer>
</div>
<script id="cdrom-row-tmpl" type="text/html">
<div>
--
1.8.5.3