Re: [Kimchi-devel] [WOK] [RFC} Checking Bootstrap 4 compatibility + dropping jQuery Bootgrid

On 5/23/16 10:30 PM, Samuel Henrique De Oliveira Guimaraes wrote: > > Hi team, > > Last year Twitter announced the new version of Bootstrap. Wok > currently uses a customized version of Bootstrap 3 Sass / SCSS files > and looking at the Alpha code it seems that porting Wok to the new > version won’t be difficult: > > http://v4-alpha.getbootstrap.com/migration/ > Samuel, Thanks for the RFC !!! For my education, is this official final bootstrap 4 version or is it still kind of non stable version (alpha sounds like that to me) ? If so when will be the official bootstrap 4 ? > > -Browser Support: Ok! > > -SCSS environment: Ok! > > -Dropped glyphicons: Ok! We already use Font-Awesome > > - Non-responsive usage of Bootstrap is no longer supported: Ok! > > I recognize some classes from this document and I think that a minor > drawback would be with the Media Queries that were already > implemented throughout the application and some changes with the > classes names. Ginger uses a lot of “panel-“ classes that were > replaced by “cards”, the “btn-default” button was renamed to > “btn-secondary” and etc. > > The major issue is with jQuery Bootgrid plugin. It seems that they’re > not planning to port to Bootstrap 4 until it gets stable. I think we > should port our jQuery Bootgrid code to Datatables.net, since it has > a vast documentation and it already supports Bootstrap 4: > > https://datatables.net/examples/styling/bootstrap4.html > > Any comments? > This will be major concerns as I feel lot of work if we have to do this. When you say "It seems that they’re not planning to port to Bootstrap 4 until it gets stable"? Do you mean until bootstrap 4 not stabilized bootgrid team will not port or bootgrid itself have stabilization issues and they would not port until they stabilize bootgrid ? If we have an answer that bootgrid team will wait till bootstrap 4 get stabilized then I would not hurry in porting our jQuery Bootgrid code to Datatables.net, since it will involve huge effort in porting and at the same time in testing.

So in my opinion, readiness is good idea but at the same time we have to make sure we are not spending efforts in porting any of the existing code unless we know that there will be no support at all !!! We have to take conscious decision !!! > > Samuel > > > > _______________________________________________ > Kimchi-devel mailing list > Kimchi-devel(a)ovirt.org > http://lists.ovirt.org/mailman/listinfo/kimchi-devel _______________________________________________ Kimchi-devel mailing list Kimchi-devel(a)ovirt.org http://lists.ovirt.org/mailman/listinfo/kimchi-devel