Reviewed-By: Zhou Zheng Sheng <zhshzhou@linux.vnet.ibm.com> Tested-By: Zhou Zheng Sheng <zhshzhou@linux.vnet.ibm.com> Test on the current Kimchi code and it passes. Then make some wrong format strings manually, and "make check-local" reports it successfully. on 2014/04/02 14:37, shaohef@linux.vnet.ibm.com wrote:
From: ShaoHe Feng <shaohef@linux.vnet.ibm.com>
When I do i18n translation, I find some string format are wrong. So I add a check-local command to help the developer to check their string format.
Every developers please run this command before submit your patch. Thanks.
After you run this command, it may report some invalid string formats. $ make check-local Checking for invalid string formatting... "KCHREPOS0018E": _("Could not write repository configuration file %(repo_file)"),
You should check %(repo_file) is what you want.
Ref: http://docs.python.org/2/library/string.html
Signed-off-by: ShaoHe Feng <shaohef@linux.vnet.ibm.com> Signed-off-by: Zhou Zheng Sheng <zhshzhou@linux.vnet.ibm.com> Signed-off-by: Christy Perez <christy@linux.vnet.ibm.com> --- Makefile.am | 8 ++++++++ 1 file changed, 8 insertions(+)
diff --git a/Makefile.am b/Makefile.am index c68f050..915537d 100644 --- a/Makefile.am +++ b/Makefile.am @@ -73,7 +73,15 @@ PEP8_WHITELIST = \
SKIP_PYFLAKES_ERR = "\./src/kimchi/websocket\.py"
+I18N_FILES = plugins/*/i18n.py \ + src/kimchi/i18n.py \ + $(NULL) + check-local: + @echo "Checking for invalid string formatting..." + @grep -P "%\([^\)]*\)[^0-9\.bcdeEfgGnosxX%]" $(I18N_FILES) | \ + while read LINE; do echo "$$LINE"; false; done + @echo "Checking for invalid string formatting successfully" find . -path './.git' -prune -type f -o \ -name '*.py' -o -name '*.py.in' | xargs $(PYFLAKES) | \ grep -w -v $(SKIP_PYFLAKES_ERR) | \
-- Thanks and best regards! Zhou Zheng Sheng / 周征晟 E-mail: zhshzhou@linux.vnet.ibm.com Telephone: 86-10-82454397