Re: [Kimchi-devel] [RFC] Changes to "disks" attribute of template creation API to support s390 architecture

Hi All, (I am back \o/) I'd recommend to find a solution which affects as less as possible the current design we have today as the community code freeze for 2.3 release is on next week. Said that, the solution we agree in this RFC will be specific for s390x systems. Any problem on that? That means, that in the code we will need to check the system arch to identify on which way to follow. For this storage pool specific issue, I'd say to have a template.conf file for s390x systems and change the 'pool' parameter for 'dirpath' Something like: [storage] # Specify multiple [[disk.X]] sub-sections to add multiples disks to guest # Each disk files will be created in respective storage pool set [[disk.0]] # Disk size in GB #size = 10 # Disk format #format = qcow2 *# Directory to handle the guest disk ** **#dirpath = /var/lib/kimchi/images** * When parsing the template.conf file, make sure to validate the data according to system arch. if s390x: if not dirpath: raise InvalidOperation('You need to specify the directory to handle the guest disk') elif not pool: raise InvalidOperation('You need to specify the pool to handle the guest disk') That will imply in changing the way the templates and the guests are created. Today we have the 'disks' parameter which also needs pool information. Following the same approach, the pool information would be replaced by dirpath only for s390x systems. What do you think about that? Maybe we need to think more about the details but the overall idea is that. I will check the RFC about virtual networks and reply separated there. Regards, Aline Manera On 08/10/2016 03:28 AM, Pooja Kulkarni wrote: