On 30/01/2015 14:11, Christy Perez wrote:
The only pep8 issue I see is the one that's always there (that wasn't caused by this change):
Checking for invalid i18n string... KCHUTILS0003E is obsolete, it is no longer in use make: *** [check-local] Error 1
Do you see a different one?
Yeap! Probably we are using a different pep8 version. alinefm@alinefm:~/kimchi$ sudo make check-local [sudo] password for alinefm: PYTHONPATH=src contrib/check_i18n.py plugins/*/i18n.py src/kimchi/i18n.py Checking for invalid i18n string... Checking for invalid i18n string successfully find . -path './.git' -prune -type f -o \ -name '*.py' -o -name '*.py.in' | xargs /usr/bin/pyflakes | \ grep -w -v "\./src/kimchi/websocket\.py" | \ while read LINE; do echo "$LINE"; false; done /usr/bin/pep8 --version 1.5.6 /usr/bin/pep8 --filename '*.py,*.py.in' --exclude="*src/kimchi/config.py,*src/kimchi/i18n.py,*tests/test_config.py" . ./src/kimchi/control/base.py:115:18: E127 continuation line over-indented for visual indent ./src/kimchi/control/base.py:115:80: E501 line too long (88 > 79 characters) ./src/kimchi/control/networks.py:23:1: E302 expected 2 blank lines, found 1 ./src/kimchi/control/networks.py:39:70: E502 the backslash is redundant between brackets ./src/kimchi/control/networks.py:40:13: E128 continuation line under-indented for visual indent ./src/kimchi/control/storagepools.py:82:13: E128 continuation line under-indented for visual indent ./src/kimchi/control/vms.py:24:1: E302 expected 2 blank lines, found 1 ./src/kimchi/control/vms.py:43:13: E128 continuation line under-indented for visual indent ./src/kimchi/control/vms.py:45:13: E128 continuation line under-indented for visual indent ./src/kimchi/control/vms.py:47:13: E128 continuation line under-indented for visual indent Makefile:828: recipe for target 'check-local' failed make: *** [check-local] Error 1
On 01/30/2015 08:40 AM, Aline Manera wrote:
Please, run "make check-local" to fix the pep8 issues.
On 27/01/2015 16:39, Christy Perez wrote:
In order to prevent benign error messages from being displayed to the user, some POST requests for transient objects should be handled as special cases.
This patchset introduces a way to mark an action as destructive so that the subsequent GET after a POST is bypassed. It also adds that logic to the three types of transient objects that Kimchi deals with: VMs, Networks, and Storage Pools.
Christy Perez (4): Handle requests differently for transient objects Transient VM POST request handling Transient Network POST request handling Transient StoragePool POST request handling
src/kimchi/control/base.py | 14 +++++++++----- src/kimchi/control/networks.py | 4 ++-- src/kimchi/control/storagepools.py | 4 ++-- src/kimchi/control/vms.py | 10 ++++++---- src/kimchi/i18n.py | 1 + src/kimchi/model/vms.py | 3 +++ 6 files changed, 23 insertions(+), 13 deletions(-)