Re: [Kimchi-devel] [PATCH v3 0/4] Transient Object Handling
The only pep8 issue I see is the one that's always there (that wasn't
caused by this change):
Checking for invalid i18n string...
KCHUTILS0003E is obsolete, it is no longer in use
make: *** [check-local] Error 1
Do you see a different one?
On 01/30/2015 08:40 AM, Aline Manera wrote:
Please, run "make check-local" to fix the pep8 issues.
On 27/01/2015 16:39, Christy Perez wrote:
> In order to prevent benign error messages from being displayed to the
> user, some POST requests for transient objects should be handled as
> special cases.
>
> This patchset introduces a way to mark an action as destructive
> so that the subsequent GET after a POST is bypassed. It also
> adds that logic to the three types of transient objects
> that Kimchi deals with: VMs, Networks, and Storage Pools.
>
> Christy Perez (4):
> Handle requests differently for transient objects
> Transient VM POST request handling
> Transient Network POST request handling
> Transient StoragePool POST request handling
>
> src/kimchi/control/base.py | 14 +++++++++-----
> src/kimchi/control/networks.py | 4 ++--
> src/kimchi/control/storagepools.py | 4 ++--
> src/kimchi/control/vms.py | 10 ++++++----
> src/kimchi/i18n.py | 1 +
> src/kimchi/model/vms.py | 3 +++
> 6 files changed, 23 insertions(+), 13 deletions(-)
>