On 03/13/2014 05:51 AM, Adam King wrote:
The original patch series leaves the "loading" image displayed over the debug reports indefinistly. This patch corrects that error, as well as centering the images over the grid. Thanks for the fixes! Though I noticed it and sent a patch to fix it. Sorry for my late patch. See comments inline. No worries. Trying to get these closed out before end of iteration...
Signed-off-by: Adam King <rak@linux.vnet.ibm.com> --- ui/css/theme-default/grid.css | 10 ++++++---- ui/js/src/kimchi.grid.js | 2 +- 2 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/ui/css/theme-default/grid.css b/ui/css/theme-default/grid.css index 761d32f..958bdb0 100644 --- a/ui/css/theme-default/grid.css +++ b/ui/css/theme-default/grid.css @@ -218,21 +218,23 @@ left: 0; position: absolute; right: 0;
+ top: 48px; It's already calculated dynamically because there may be no title bar or toolbar. Don't hard-code here. I didn't realize. Calculation should override making this redundant,
On 03/12/2014 11:30 PM, Hongliang Wang wrote: though I don't recall seeing that.
}
.grid-loading { bottom: 0;
- height: 68px; + height: 100%; left: 0; margin: auto; right: 0; text-align: center; top: 0; - width: 49px; + width: 100%; Adding a "position: absolute;" will center it both horizontally and vertically. I found a way to center that worked for me. I don't object if you offer a patch that does it better. }
.grid-loading-icon { background: url("../images/theme-default/kimchi-loading.gif") no-repeat left top; - height: 48px; - width: 49px; + height: 100%; + width: 100%; + background-position: center; Don't change the size of icon. Icon size doesn't actually change, at least not in my tests. } diff --git a/ui/js/src/kimchi.grid.js b/ui/js/src/kimchi.grid.js index c53e584..2e3d0ed 100644 --- a/ui/js/src/kimchi.grid.js +++ b/ui/js/src/kimchi.grid.js @@ -54,7 +54,7 @@ kimchi.widget.Grid = function(params) { '<div class="grid-resizer hidden"></div>', '</div>', '<div class="grid-footer"></div>', - '<div class="grid-mask">', + '<div class="grid-mask hidden">', That's right. '<div class="grid-loading">', '<div class="grid-loading-icon"></div>', '<div class="grid-loading-text"></div>',
-- Adam King <rak@linux.vnet.ibm.com> IBM CSI