Re: [Kimchi-devel] [PATCH] [Kimchi] Issue #791: New UI for adding network bridges

Aline, Even when the VLAN checkbox is not selected, the backend is validating the VLAN ID field.

If the VLAN ID is required for bridged with nic or bonding interface, I don't see a reason for a checkbox in the UI. 2016-02-05 15:36 GMT-02:00 Aline Manera <alinefm(a)linux.vnet.ibm.com <mailto:alinefm@linux.vnet.ibm.com>>: On 02/05/2016 03:12 PM, Peter Pennings wrote: > Hi > > I'm working on a V2 patch for this issue and I have one doubt. > Now, I'm showing the VLAN option when a bridged is selected with > a NIC or bonding interface. In this case, the VLAN ID is required > or can be empty? I guess backend is validating this and turned > this field obrigatory. > When VLAN is selected, a VLAN tag is required. > Thanks > > Peter > > 2016-02-05 10:01 GMT-02:00 Aline Manera > <alinefm(a)linux.vnet.ibm.com <mailto:alinefm@linux.vnet.ibm.com>>: > > > Hi Peter, > > Even selecting a NIC interface, the VLAN option is not being > displayed for a Bridged network. > > You can try it by yourself too. > > > On 02/05/2016 09:18 AM, Peter Pennings wrote: >> I followed bellow specifications, the VLAN form should be >> showed when a NIC or bonding is selected. Is that not being >> showed? >> >> https://github.com/kimchi-project/kimchi/issues/791 >> >> *Bridged option new behaviour:* >> 1) Change description of "Bridged" option to refer to Linux >> bridges and OVS bridges (no more direct connections) >> 2) When "Bridged" is selected, "Destination" will show all >> the interfaces it currently shows plus OVS bridges >> *3) "Enable VLAN" will only be showed if user selects a NIC >> or bonding from "Destination" pop-up*(alternatively, we can >> show it always and block the usage of VLAN with NIC or >> bonding selected) >> 4) "Bridged" option will call network_create API with >> "bridge" as value for "connection" parameter >> >> *New macvtap option:* >> 5) Add a new option "macvtap" to Network Type, with same >> current description of today's Bridged option >> 6) When macvtap option is selected, "Destination" will show >> only NICs and bondings. It will NOT show any kind of bridges >> anymore. >> *7) "Enable VLAN" option is NOT showed* >> 8) macvtap option will call network create API with >> "macvtap" as "connection" parameter value. >> >> >> I will send a V2 patch with the others corrections (function >> name and alert messages). If V1 patch is not according with >> the above specifications, please, let me know, then I can >> fix it. >> >> >> Thanks >> >> >> Peter >> >> >> 2016-02-04 16:50 GMT-02:00 Lucio Correia >> <luciojhc(a)linux.vnet.ibm.com >> <mailto:luciojhc@linux.vnet.ibm.com>>: >> >> On 04-02-2016 15:38, Lucio Correia wrote: >> >> I will run some tests now with this and send more >> comments afterwards. >> Here are my review comments. Additional comments in >> the code. >> >> >> The only problem I noticed is that VLAN form is not >> being showed when I select Linux and OVS bridges. >> >> >> -- >> Lucio Correia >> Software Engineer >> IBM LTC Brazil >> >> _______________________________________________ >> Kimchi-devel mailing list >> Kimchi-devel(a)ovirt.org <mailto:Kimchi-devel@ovirt.org> >> http://lists.ovirt.org/mailman/listinfo/kimchi-devel >> >> >> >> >> _______________________________________________ >> Kimchi-devel mailing list >> Kimchi-devel(a)ovirt.org <mailto:Kimchi-devel@ovirt.org> >> http://lists.ovirt.org/mailman/listinfo/kimchi-devel > >