Re: [Kimchi-devel] [PATCH 0/3] Fix: Do not pass 'bus' param when attaching disk
The patch set looks good and it's working in general (read as,
automatically choose the correct bus), except by the device parameter
used in the new disk attached.
In all my tests (x86 and Power), all the disks attached is set to use
'hda', instead of the sequential device - if already exists a 'hda'
device the next one must be 'hdb'.
Also, even for SCSI and Virtio, the device set up is 'hda', instead of
'vd?' or 'sd?' respectively.
--
Paulo Ricardo Paz Vital <pvital(a)linux.vnet.ibm.com>
IBM Linux Technology Center
On Fri, 2014-08-01 at 16:19 +0800, lvroyce(a)linux.vnet.ibm.com wrote:
From: Royce Lv <lvroyce(a)linux.vnet.ibm.com>
We passed 'IDE' for default value when attaching cdrom,
but 'IDE' bus is not supported on some platform(e.g. power),
In fact, kimchi has a embeded scheme to decide which bus is proper,
so let backend to decide which bus to use when attaching disk.
Royce Lv (3):
Delete 'bus' param from backend
Delete 'bus' selection from UI
Update testcases for bus type decision making
src/kimchi/API.json | 6 ------
src/kimchi/model/vmstorages.py | 3 +--
tests/test_model.py | 34 ++++++++++++++++++------------
ui/js/src/kimchi.guest_storage_add.main.js | 28 ------------------------
ui/pages/guest-storage-add.html.tmpl | 13 ------------
5 files changed, 22 insertions(+), 62 deletions(-)