11:23 a.m.
Thanks, I am going to fix this
On 05/26/2015 03:12 PM, CrÃstian Deives wrote:
This patchset breaks some tests when running "make check"
on Fedora 21.
Also, why do we need to create the subresource "memdevices"? Why can't
we hotplug memory by setting a new value to the VM 'memory', as in:
PUT /vms/myvm {'memory': 1000}
On 25-05-2015 18:18, Rodrigo Trujillo wrote:
> This patchset implements the backend part of memory hotplug
> functionality,
> including:
> - new feature test to check if libvirt supports memory devices
> - changes the way that memory is assigned or updated in the guest xml:
> * memory is now set in a basic NUMA node
> - includes maxMemory element in the XML:
> * which is equal the total memory of the host
> * sets memory device slots. The total number of slots are equal the
> maxMemory minus the memory assigned (1 slot == 1 GB )
> - creates a new VM device, the memory device:
> * by default, a memory device will have 1GB
> * user can add the memory device with machine running or offline
> - memory devices are selected according to its position in the xml
> (the slot)
> 0, 1, 2, etc
>
> URL:
> - http://localhost:8010/vms/<VM>/memdevices
> - http://localhost:8010/vms/<VM>/memdevices/<MEM-DEV>
>
> Rodrigo Trujillo (5):
> [Memory HotPlug] Feature test to check support to memory devices
> [Memory HotPlug] Add maxMemory and numa configuration to guest xml
> [Memory HotPlug] Memory device control and model classes
> [Memory HotPlug] Add parameters checking and documentation to memory
> device API
> [Memory HotPlug] Fix VM offline memory update and fix slots
> assignment
>
> docs/API.md | 16 +++++++
> src/kimchi/API.json | 14 +++++-
> src/kimchi/control/vm/memdevices.py | 47 +++++++++++++++++++
> src/kimchi/i18n.py | 5 ++
> src/kimchi/model/config.py | 3 ++
> src/kimchi/model/featuretests.py | 43 +++++++++++++++++
> src/kimchi/model/vmmemdevices.py | 94
> +++++++++++++++++++++++++++++++++++++
> src/kimchi/model/vms.py | 77
> +++++++++++++++++++++++++-----
> src/kimchi/vmtemplate.py | 40 ++++++++++++----
> 9 files changed, 316 insertions(+), 23 deletions(-)
> create mode 100644 src/kimchi/control/vm/memdevices.py
> create mode 100644 src/kimchi/model/vmmemdevices.py
>
_______________________________________________
Kimchi-devel mailing list
Kimchi-devel(a)ovirt.org
http://lists.ovirt.org/mailman/listinfo/kimchi-devel