On 03/07/2014 03:13 PM, Aline Manera wrote:
It will not work in most of cases.
1. The default network and storage pool is usually created by libvirt with the default values. So an kimchi user will face the same issue while running kimchi on nested virtualization. I.e, there is not way to fix it. Just warning the user about the problem.
Yeap, there is something we can do. If kimchih fails to start the default network because the address is already in use we can automatically update the default network address by using get_free_network()
2. This issue is in some way related to https://github.com/kimchi-project/kimchi/issues/265 And why should not the user delete default network/storage pool? This limitation should be impose to user when a network/storage pool is used by a template or vm. Otherwise, the user can remove it.
Usually the default network/storage pool is created by libvirt. But some time ago, we identified it did not happen in some distros. And as the Kimchi default configuration for templates is pointing to those resources we decided to create them manually on kimchi code to avoid problems while using the templates.
So my proposal is: let's revisit all the supported distros and check if libvirt creates default network/storage pool by default, and if so remove this code from kimchi. Then default network/storage pool will have the same behavior from other networks/storage pools.
I thought more about that and while creating a template user only provides the ISO file and all other configuration is provided by kimchi. Which means we will always set the default network and storage pool for a new template. So default network and storage pool are special resources for kimchi and they should not be deactivated or removed otherwise we will create inconsistent templates from scratch
On 03/07/2014 06:52 AM, shaohef@linux.vnet.ibm.com wrote:
From: ShaoHe Feng <shaohef@linux.vnet.ibm.com>
let 'create' attr of networks model to create the default network
ShaoHe Feng (3): move _default_network_check from top model to networks model add a new function to get an available network address Issue #302: let 'create' attr of networks model to create default network
src/kimchi/model/model.py | 35 --------------------------------- src/kimchi/model/networks.py | 46 +++++++++++++++++++++++++++++++++++++------- src/kimchi/network.py | 7 +++++-- 3 files changed, 44 insertions(+), 44 deletions(-)
_______________________________________________ Kimchi-devel mailing list Kimchi-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/kimchi-devel