8:27 a.m.
On 02/28/2017 10:02 AM, Lucio Correia wrote:
On 27/02/2017 18:30, Daniel Henrique Barboza wrote:
>
>
> On 02/27/2017 06:18 PM, Lucio Correia wrote:
>> On 27/02/2017 18:12, Daniel Henrique Barboza wrote:
>>>>>> +BASE_DIRECTORY = '/run'
>>>>> Suggestion to use:
>>>>> os.path.join('/run/user', str(os.getuid()))
>>>>> in order tests may be run with root.
>>>
>>> I would prefer to choose a path that can be written by anyone else to
>>> allow the push_server
>>> to be started without root.
>>
>> Sorry, I meant *without* root.
>> /run/user/<UID> allows for that, it's writable by the user that
>> started wokd, be it root or not.
>>
> This change would require further UI changes to allow the /config API
> (or other) to inform
> the UI of the current websocket URL. This will not solve the problems
> I've seen with the unit tests
> though - multiple instances of the push_server will not be possible and
> the unit tests will
> break.
I'm not seeing the relation between that BASE_DIR and the URL used by
UI. Anyway, I believe we both agree that just one server and one URL
is fine.
My only concern is the directory to save that woknotifications file
and the permissions required for it.
If the websockets directory path would be returned by a function in
config.py (for example) the tests may overwrite that to set a /tmp dir
and that way allowing it to run without root permissions.
Daniel helped me to use @mock.patch and seems it can be a good way to go
to solve it.
>
> We need to discuss an alternative where:
>
> - any user can start the push_server, as you require
I'm not requiring it. Just saying that if it will be started by tests,
it needs to run without sudo (i.e. use paths in filesystems that allow
for that).
As I mentioned earlier, testing for 'test' option is not enough to
avoid PushServer to be started during tests, since as of now 'test'
option only governs which model will be used.
>
> - if we're to allow the push_server to be run in test_mode*, we need to
> think in a way of
> generating random paths that can be written by any user as well. You are
> working closely
> in Debian changes. What system dir can be used that can be written by
> any user and,
> preferably, exists in RPM distros too?
On Fedora 25, /run/user/<UID>/libvirt is the default dir used to store
runtime data by libvirt when it is started with "qemu:///session" url
(regular user session).
In fact it seems to be default place for that kind of usage in both
distros:
Ubuntu 16.04:
$ ls /run/user/1000/
dbus-session gnome-shell gvfs-burn pulse systemd
upstart-dbus-bridge.4451.pid upstart-udev-bridge.2946.pid
dconf gvfs keyring speech-dispatcher upstart
upstart-file-bridge.4451.pid upstart-udev-bridge.4451.pid
Fedora 25:
$ ls /run/user/1000/
bus libvirt systemd