Re: [Kimchi-devel] [PATCH] [Kimchi 0/4] adding 'console' parameter for s390x arch
On 09/13/2016 02:12 AM, Aline Manera wrote:
Hi Suresh,
Please, add a meaningful commit message for each patch.
Every patch named as "adding console parameter for s390x arch" does
seem right to me. If so, why do you need 4 patch instead of one?
this patch adds
console option for templates and vms api. I will prepare
two patches and send it with appropriate commit message
Regards,
Aline Manera
On 09/08/2016 07:33 AM, sureshab(a)linux.vnet.ibm.com wrote:
> From: Suresh Babu Angadi <sureshab(a)in.ibm.com>
>
> For s390x, console can be either sclp/virtio.
> This patch set enables, listing and update of 'console'
> parameter for templates and vms when running on s390x
>
> Suresh Babu Angadi (4):
> for s390x, console can be either virtio/sclp
> this patch adds additional parameter 'console' to
> templates for s390x architecture.
> this patch adds additional parameter 'console' to vms,
> for s390x architecture.
> added error codes and json attribute for update of 'console'
>
> API.json | 24 ++++++++++++++---
> control/templates.py | 1 +
> i18n.py | 2 ++
> model/templates.py | 6 +++++
> model/vms.py | 75
> +++++++++++++++++++++++++++++++++++-----------------
> osinfo.py | 4 +++
> xmlutils/serial.py | 6 ++++-
> 7 files changed, 90 insertions(+), 28 deletions(-)
>
--
Regards,
Suresh Babu Angadi